Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#27784 closed New feature (duplicate)

Custom Site model support for django.contrib.sites.

Reported by: Massimo Scamarcia Owned by: nobody
Component: contrib.sites Version: dev
Severity: Normal Keywords: sites swappable models
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Support for custom Site model in django.contrib.sites to add model fields and change default manager.

Change History (5)

comment:1 by Massimo Scamarcia, 7 years ago

Pull Request: https://github.com/django/django/pull/7961

Should I push to ticket_27784 instead?

comment:2 by Tim Graham, 7 years ago

Resolution: duplicate
Status: newclosed

Duplicate of #22779. The latest discussion on the mailing list suggested replacing the model with settings may be a better approach.

in reply to:  2 comment:3 by Massimo Scamarcia, 7 years ago

Replying to Tim Graham:

Duplicate of #22779. The latest discussion on the mailing list suggested replacing the model with settings may be a better approach.

I personally dislike the settings based solutions as there are many pluggable apps and projects that are importing Site directly from django.contrib.sites.models. imho this feature should work exactly like the customization of django.contrib.auth.models.User.

comment:4 by Tim Graham, 7 years ago

You should continue the discussion on the mailing list. We won't make a change either way without a consensus there.

in reply to:  4 comment:5 by Massimo Scamarcia, 7 years ago

Replying to Tim Graham:

You should continue the discussion on the mailing list. We won't make a change either way without a consensus there.

Ok thanks, I will do.

Note: See TracTickets for help on using tickets.
Back to Top