Opened 4 years ago

Closed 4 years ago

Last modified 17 months ago

#22779 closed New feature (needsinfo)

Swappable Site

Reported by: German M. Bravo Owned by: nobody
Component: contrib.sites Version: 1.6
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


As noted by #15089 and #21381, it'd be nice to have more flexibility regarding the sites contrib app. I'm attaching a patch that makes django.contrib.sites Site model swappable under v1.6. The patch requires an accepted ticket (#21391) abut lazy signals (I backported it from 1.7 to 1.6), and with that it passes all tests.

Attachments (1)

#22779-swappable_sites.diff (17.6 KB) - added by German M. Bravo 4 years ago.

Download all attachments as: .zip

Change History (4)

Changed 4 years ago by German M. Bravo

Attachment: #22779-swappable_sites.diff added

comment:1 Changed 4 years ago by Aymeric Augustin

Component: Uncategorizedcontrib.sites
Type: UncategorizedNew feature

Interesting idea. Can you explain your use case and why you're suggestion this solution on django-developers?

comment:2 Changed 4 years ago by Tim Graham

Resolution: needsinfo
Status: newclosed

Closing as "needs info" until the required discussion happens.

comment:3 Changed 17 months ago by Massimo Scamarcia

This would be really useful to allow customization of SiteManager and get_current method and adding new fields. Many companies and customers asked me to do that during these years. Most of the times I was forced to roll my own sites app, that's the reason why I have contributed too. My ticket is currently closed as it is a duplicate ( Do you have any plan to merge this patch on master branch soon?

Last edited 17 months ago by Massimo Scamarcia (previous) (diff)
Note: See TracTickets for help on using tickets.
Back to Top