Opened 7 years ago

Closed 22 months ago

Last modified 8 months ago

#27471 closed New feature (fixed)

Make admin's list_filter choices collapsable

Reported by: Greg McCoy Owned by: Marcelo Galigniana
Component: contrib.admin Version: 1.10
Severity: Normal Keywords: filter admin collaspe
Cc: Carlton Gibson Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

I made a change to my site to add a toggle collapse on the filters in the admin page. Is this something we'd like in Django by default?

Attachments (1)

screenshot.png (13.5 KB ) - added by Greg McCoy 7 years ago.

Download all attachments as: .zip

Change History (18)

by Greg McCoy, 7 years ago

Attachment: screenshot.png added

comment:1 by Tim Graham, 7 years ago

Has patch: unset
Summary: Collaspable filters in AdminMake admin's list_filter choices collapsable
Triage Stage: UnreviewedAccepted

Sure, it was proposed in wiki:DjangoDesign#Collapsefiltersinchangelistsidebar:

Filter options take of a lot of vertical space in the changelist sidebar. This makes it difficult to use fields with lots of options as filters, or to use more than a few fields as filters. This could be solved by adding an option to display filters with more than a specified number of options as a select element instead of in a list. (WM)

#21183 is a related ticket about collapsing the entire sidebar.

comment:2 by Tim Graham, 7 years ago

Has patch: set
Needs documentation: set
Needs tests: set

PR (without tests or documentation updates -- some screenshots need to be updated, for example).

comment:3 by Shiv K Sah, 7 years ago

Owner: changed from nobody to Shiv K Sah
Status: newassigned

comment:4 by Mariusz Felisiak, 2 years ago

Owner: Shiv K Sah removed
Status: assignednew

comment:5 by Mariusz Felisiak, 2 years ago

Cc: Carlton Gibson added

Related to the #21183 which is about toggling specific filters, not the entire filter block. I'm not sure we need both 🤔.

comment:6 by Marcelo Galigniana, 2 years ago

Has patch: unset
Owner: set to Marcelo Galigniana
Status: newassigned

comment:7 by Marcelo Galigniana, 2 years ago

Has patch: set
Needs tests: unset
Last edited 2 years ago by Marcelo Galigniana (previous) (diff)

comment:8 by Claude Paroz, 2 years ago

Needs documentation: unset
Patch needs improvement: set

comment:9 by Marcelo Galigniana, 2 years ago

Patch needs improvement: unset

comment:10 by Mariusz Felisiak, 2 years ago

Patch needs improvement: set

comment:11 by Marcelo Galigniana, 2 years ago

Patch needs improvement: unset

Here I add the 2nd approach PR using summary/details elements

comment:12 by Carlton Gibson, 2 years ago

Patch needs improvement: set

comment:13 by Marcelo Galigniana, 23 months ago

Patch needs improvement: unset
UI/UX: unset

The disclosure element was re-styled and persistence logic added!

Last edited 23 months ago by Marcelo Galigniana (previous) (diff)

comment:14 by Mariusz Felisiak, 23 months ago

Patch needs improvement: set

comment:15 by Mariusz Felisiak, 23 months ago

Patch needs improvement: unset
Triage Stage: AcceptedReady for checkin

comment:16 by Mariusz Felisiak <felisiak.mariusz@…>, 22 months ago

Resolution: fixed
Status: assignedclosed

In 27aa7035:

Fixed #27471 -- Made admin's filter choices collapsable.

comment:17 by GitHub <noreply@…>, 8 months ago

In 4a72da71:

Refs #27471 -- Made admin's filter choice arrows use cursor pointers.

Note: See TracTickets for help on using tickets.
Back to Top