Opened 6 years ago

Closed 7 months ago

#27451 closed Bug (invalid)

syndication feed may crash with AmbiguousTimeError

Reported by: Markus Holtermann Owned by: nobody
Component: contrib.syndication Version: 1.10
Severity: Normal Keywords:
Cc: Carlton Gibson Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Tim Graham)

Having a naive time in DST and turning it into a STD results in an AmbiguousTimeError in django/contrib/syndication/views.py for pubdate, updatedate and possibly others.

https://sentry.io/share/issue/33303436382e313737363032343732/

Change History (4)

comment:1 Changed 6 years ago by Tim Graham

Description: modified (diff)
Summary: AmbiuousTimeError in syndication feedsyndication feed may crash with AmbiguousTimeError
Triage Stage: UnreviewedAccepted

I'm not sure what the proper resolution is. Perhaps providing a value for the is_dst argument of make_aware(), but what value to use?

comment:2 Changed 2 years ago by Tobias McNulty

I am not sure about a fix, but we did see another one of these over the weekend during the time change: https://sentry.io/share/issue/ea6b31e26e164a03903f499ca7f87b29/

comment:3 in reply to:  2 Changed 2 years ago by Claude Paroz

Replying to Tobias McNulty:

I am not sure about a fix, but we did see another one of these over the weekend during the time change: https://sentry.io/share/issue/ea6b31e26e164a03903f499ca7f87b29/

It looks like this one could be fixed by making item_pubdate an aware datetime in the first place.

comment:4 Changed 7 months ago by Mariusz Felisiak

Cc: Carlton Gibson added
Resolution: invalid
Status: newclosed
Triage Stage: AcceptedUnreviewed

The is_dst argument is deprecated and will be removed in Django 5.0 (see #32365). Closing as no longer valid.

Note: See TracTickets for help on using tickets.
Back to Top