Opened 8 years ago
Closed 3 years ago
#27451 closed Bug (invalid)
syndication feed may crash with AmbiguousTimeError
Reported by: | Markus Holtermann | Owned by: | nobody |
---|---|---|---|
Component: | contrib.syndication | Version: | 1.10 |
Severity: | Normal | Keywords: | |
Cc: | Carlton Gibson | Triage Stage: | Unreviewed |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description (last modified by )
Having a naive time in DST and turning it into a STD results in an AmbiguousTimeError
in django/contrib/syndication/views.py
for pubdate
, updatedate
and possibly others.
https://sentry.io/share/issue/33303436382e313737363032343732/
Change History (4)
comment:1 by , 8 years ago
Description: | modified (diff) |
---|---|
Summary: | AmbiuousTimeError in syndication feed → syndication feed may crash with AmbiguousTimeError |
Triage Stage: | Unreviewed → Accepted |
follow-up: 3 comment:2 by , 4 years ago
I am not sure about a fix, but we did see another one of these over the weekend during the time change: https://sentry.io/share/issue/ea6b31e26e164a03903f499ca7f87b29/
comment:3 by , 4 years ago
Replying to Tobias McNulty:
I am not sure about a fix, but we did see another one of these over the weekend during the time change: https://sentry.io/share/issue/ea6b31e26e164a03903f499ca7f87b29/
It looks like this one could be fixed by making item_pubdate an aware datetime in the first place.
comment:4 by , 3 years ago
Cc: | added |
---|---|
Resolution: | → invalid |
Status: | new → closed |
Triage Stage: | Accepted → Unreviewed |
The is_dst
argument is deprecated and will be removed in Django 5.0 (see #32365). Closing as no longer valid.
I'm not sure what the proper resolution is. Perhaps providing a value for the
is_dst
argument ofmake_aware()
, but what value to use?