Opened 5 years ago

Closed 4 years ago

#27156 closed Bug (fixed)

Setting HttpRequest.encoding should clear GET

Reported by: Tim Graham Owned by: PREMANAND
Component: HTTP handling Version: 1.10
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

Discovered in #27113, commit d7a4b156d935ffcb8cdd9290688457453fc06b24 broke clearing of request.GET when request.encoding changes. I think the line in the encoding.settr needs to use del self.GET instead of del self._get.

Change History (5)

comment:1 Changed 5 years ago by PREMANAND

Owner: changed from nobody to PREMANAND
Status: new → assigned

comment:2 Changed 4 years ago by PREMANAND

Has patch: set

comment:4 Changed 4 years ago by Tim Graham

Patch needs improvement: set

The test doesn't pass on Python 2.

comment:5 Changed 4 years ago by Tim Graham <timograham@…>

Resolution: → fixed
Status: assigned → closed

In 371adc4:

Fixed #27156 -- Made changing HttpRequest.encoding clear GET.

Note: See TracTickets for help on using tickets.
Back to Top