Opened 15 months ago

Last modified 15 months ago

#27109 new New feature

Make Flatpage swappable

Reported by: Vlastimil Zíma Owned by: nobody
Component: contrib.flatpages Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

It's kind of a long shot, but I give it a try.

Let's make Flatpage swappable. I've opened a discussion about the feature at https://groups.google.com/d/msg/django-developers/WFdCEpB-fMM/6rRae4QLBgAJ. Despite the little support at developers, I suspect the swap would be used once available.

There is a number of attempts to extend the flatpages

Since it is not possible to inherit custom Flatpage from an abstract Flatpage model, there are two options. Make an extra table which generates join on every use, which is ineffective, or copy the whole Flatpage application, which is terrible to maintain. There is number of projects which extends the Flatpage by copying the whole model

I assume the lack of support at developers mailing list is caused by developers who needed to extend Flatpage already did it one way or another, it most cases by copying the flatpages app as is.

The swappable is already implemented, so let's use it.

Change History (4)

comment:1 Changed 15 months ago by Aymeric Augustin

Triage Stage: UnreviewedAccepted

comment:2 Changed 15 months ago by Vlastimil Zíma

Great. So what now? Should I try to make a patch if I find a time to do so?

comment:3 Changed 15 months ago by Aymeric Augustin

Yes, submitting a pull request is the next step.

The most important part is likely documentation.

comment:4 Changed 15 months ago by Tim Graham

Before introducing another swappable model, I'd like to see the documentation about some of the known difficulties with swappable models addressed: #24370 and #25313.

Note: See TracTickets for help on using tickets.
Back to Top