Opened 8 years ago
Last modified 8 months ago
#27109 new New feature
Make Flatpage swappable
Reported by: | Vlastimil Zíma | Owned by: | nobody |
---|---|---|---|
Component: | contrib.flatpages | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Ülgen Sarıkavak | Triage Stage: | Accepted |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
It's kind of a long shot, but I give it a try.
Let's make Flatpage
swappable. I've opened a discussion about the feature at https://groups.google.com/d/msg/django-developers/WFdCEpB-fMM/6rRae4QLBgAJ. Despite the little support at developers, I suspect the swap would be used once available.
There is a number of attempts to extend the flatpages
- #18331
- #23743
- #26762
- https://groups.google.com/d/msg/django-users/hl4dO1Lxi7Y/aE82ZjNxB-cJ
- https://groups.google.com/d/msg/django-users/XluinfrJaK8/5G2ioMt5HVwJ
Since it is not possible to inherit custom Flatpage
from an abstract Flatpage
model, there are two options. Make an extra table which generates join on every use, which is ineffective, or copy the whole Flatpage
application, which is terrible to maintain. There is number of projects which extends the Flatpage
by copying the whole model
- https://github.com/danawoodman/django-flatpages-plus
- https://github.com/PragmaticMates/django-flatpages-i18n
- https://github.com/toastdriven/django-superflatpages
- https://github.com/FUUK/fuuk/tree/master/fuuk/fuflatpages
I assume the lack of support at developers mailing list is caused by developers who needed to extend Flatpage
already did it one way or another, it most cases by copying the flatpages
app as is.
The swappable
is already implemented, so let's use it.
Change History (5)
comment:1 by , 8 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:2 by , 8 years ago
comment:3 by , 8 years ago
Yes, submitting a pull request is the next step.
The most important part is likely documentation.
comment:4 by , 8 years ago
comment:5 by , 8 months ago
Cc: | added |
---|
Great. So what now? Should I try to make a patch if I find a time to do so?