Opened 9 years ago

Closed 8 years ago

#2636 closed enhancement (wontfix)

[patch] Allowed single quotes in template filter parameters

Reported by: Enrico <…> Owned by: nobody
Component: Template system Version: master
Severity: minor Keywords: template filter quotes
Cc: Triage Stage: Design decision needed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: UI/UX:


Template filters parameters requires the use of double quotes, this patch allows the use of single quotes.

Attachments (1) (1.1 KB) - added by Enrico <…> 9 years ago.

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by Enrico <…>


comment:1 Changed 9 years ago by mtredinnick

I don't really have an opinion at the moment about whether this is really needed. However, it does look like the patch is wrong: it would allow a string quoted "like this' (mismatched leading and trailing quotes). You are going to need two branchs in the reg-exp each time.

comment:2 Changed 9 years ago by anonymous

  • milestone Version 1.0 deleted

Milestone Version 1.0 deleted

comment:3 Changed 9 years ago by SmileyChris

  • Patch needs improvement set
  • Triage Stage changed from Unreviewed to Design decision needed

comment:4 Changed 8 years ago by jacob

  • Resolution set to wontfix
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.
Back to Top