Tests functions with typos are not detected by test runner

[George Marshall]

I noticed a couple of tests that either have typos or are missing the "test" keyword. This is causing them to not be detected by the test runner.

[George Marshall]

Used the following regex to find these

^[ \t]+def (?!test).*\(self\):$

[Moritz Sichert]

I ran

git grep -E '^[ \t]+def .*\(self\):$' | grep -vE 'def (__|test|setUp|tearDown)'

in the tests directory to generate the attached file. For me it doesn't look like it contains any methods that should be discovered by the test runner.

[George Marshall]

The description on the ticket is kind of ambiguous. Look at the attached pull request. This is making reference to test methods that have assertions that are not being run.

[Moritz Sichert]

Oh, I didn't see your pull request.
You are right, those two methods should be discovered.

[Claude Paroz <claude@…>]

In 75614f6d:

Fixed #26331 -- Fixed test function names with typos

[Tim Graham <timograham@…>]

In 4702c1a:

[1.9.x] Fixed #26331 -- Fixed test function names with typos

Backport of 75614f6d4c1a3fe779a75eb3e787452cccd1d814 from master

[Tim Graham <timograham@…>]

In 567658f1:

[1.8.x] Fixed #26331 -- Fixed test function names with typos

Backport of 75614f6d4c1a3fe779a75eb3e787452cccd1d814 from master