British English can't be returned from the javascript_catalog

[Doug Fish]

We have translations for British English (Australian English too!) and they aren't displayed in javascript based segments of our Django application.

Digging into the problem I believe the issue is in Django. Specifically this line:
​https://github.com/django/django/blob/master/django/views/i18n.py#L212

Ultimately makes every English variant fall back to plain "en" at
​https://github.com/django/django/blob/master/django/views/i18n.py#L248

I suggest the fix is to check for equality over starts with at line 212.

[Tim Graham]

Do you plan to submit a tested patch? It doesn't seem that reproducing the issue will be very easy for me given the sparse details you provided so far and my lack of translation expertise.

[Doug Fish]

I don't currently plan to submit such a patch. I lack the corporate approval to contribute to Django.

I shared my idea with one of my co-contributors from the OpenStack Horizon project, he tried it out and it apparently doesn't pass tests.

I'll try to sort out if I can create a small sample that will fail. Would that be helpful?

[Tim Graham]

Yes, if you can submit it as a unit test in view_tests/tests/test_i18n.py even better.

[Tim Graham]

A related ticket is #26328 -- can you say if the changes proposed there might solve your issue? (There should be a pull request soon). Maybe you can dialog with that ticket author a bit.

[Doug Fish]

I tried out the fix from the linked discussion and that will solve the issue!

[Tim Graham]

A test for this ticket is added in a ​PR from Claude.

[Claude Paroz <claude@…>]

In 11c60b5:

Reused the DjangoTranslation class for the javascript_catalog view

Thanks Tim Graham and Cristiano Coelho for the reviews.
Refs #26328, #26319.

[Claude Paroz <claude@…>]

In ecbdedfc:

Refs #26319 -- Added test for English variant in javascript_catalog

[Claude Paroz]

Hopefully fixed now.