Allow SingleObjectTemplateResponseMixin to get a template_name from form_class if it's a ModelForm

[Guilhem Saurel]

In this case, we have to set twice the model (or manually set template_name):

class ArticleForm(ModelForm):
    class Meta:
        model = Article
        fields = ['author', 'date']
    
    def clean_date(self):
        ...

class ArticleCreateView(CreateView):
    form_class = ArticleForm
    model = Article  # Redundant

A PoC to fix this is available here: ​https://github.com/nim65s/django/commit/614dae5022bb5c7d8ad0336e17ef1e0c84b9dbbf

[Berker Peksag]

Should we also make model optional for UpdateView and DeleteView?

[Guilhem Saurel]

Replying to berkerpeksag:

Should we also make model optional for UpdateView and DeleteView?

What do you mean ? Is there any code that prevents you not to add a model on an UpdateView or a DeleteView ?
In my case, I tested my PoC without any model and it worked… So it is optionnal, isn't it ?

[Guilhem Saurel]

So I've checked tests. SingleObjectMixin.get_queryset needed the same kind of modification.

Here is the updated commit:
​https://github.com/nim65s/django/commit/91f221b9e1d221d0f56213e187fcdf8e7564ded7

Tests are passing and coverage is green on my modifications.

[Tim Graham]

Could you please create a patch following our PatchReviewChecklist and send a pull request against master?

[Guilhem Saurel]

Here it is: ​https://github.com/django/django/pull/6311

[Tim Graham]

Left a few comments for improvement. Please uncheck "Patch needs improvement" after you update it. Thanks!

[Clifford Gama]

​PR