Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#26136 closed Cleanup/optimization (fixed)

JavaScript translation catalog docs contain deprecated code

Reported by: Sylvain Fankhauser Owned by: nobody
Component: Documentation Version: 1.9
Severity: Normal Keywords: i18n
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

From the 1.9 docs (https://docs.djangoproject.com/en/1.9/topics/i18n/translation/#using-the-javascript-translation-catalog):

<script type="text/javascript" src="{% url 'django.views.i18n.javascript_catalog' %}"></script>

However the ability to reverse using a Python path has been deprecated in Django 1.8. Also this doesn't make sense since in the previous example multiple catalogs are defined, so this wouldn't work anyway for multiple catalogs.

I guess the example could simply be updated to use a named route.

Change History (4)

comment:1 Changed 4 years ago by Tim Graham

Triage Stage: UnreviewedAccepted

comment:2 Changed 4 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: newclosed

In 31817dd:

Fixed #26136 -- Removed URL reversing by dotted path from JavaScript catalog example.

comment:3 Changed 4 years ago by Tim Graham <timograham@…>

In c2dfc361:

[1.8.x] Fixed #26136 -- Removed URL reversing by dotted path from JavaScript catalog example.

Backport of 31817dd2eb69db54eb559716aae42fe55ada5fea from master

comment:4 Changed 4 years ago by Tim Graham <timograham@…>

In e47f0c12:

[1.9.x] Fixed #26136 -- Removed URL reversing by dotted path from JavaScript catalog example.

Backport of 31817dd2eb69db54eb559716aae42fe55ada5fea from master

Note: See TracTickets for help on using tickets.
Back to Top