Opened 9 years ago
Closed 9 years ago
#25939 closed Cleanup/optimization (fixed)
Remove transaction from QuerySet.update_or_create's save()
Reported by: | Tim Graham | Owned by: | nobody |
---|---|---|---|
Component: | Database layer (models, ORM) | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Ready for checkin | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
According to Aymeric on the pull request:
It will have beneficial performance effects if:
ATOMIC_REQUESTS
is not in useupdate_or_create
ends up creating an object- the
save
method of that objects does long things like sending email after the write (i.e. once it holds an exclusive lock on the database)
Note:
See TracTickets
for help on using tickets.
In 423b3afc: