Opened 8 years ago

Closed 7 years ago

#25938 closed Cleanup/optimization (fixed)

deduplicate GEOSBase and GDALBase

Reported by: Sergey Fedoseev Owned by: Sergey Fedoseev
Component: GIS Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

gis.gdal.base.GDALBase and gis.geos.base.GEOSBase classes have almost the same implementation, their subclasses uses the same pattern for __del__() method, so all this logic should be factored out to a common class.

P.S.: suggestions for the name of this new common class are welcome.

Change History (8)

comment:1 by Sergey Fedoseev, 8 years ago

Owner: changed from nobody to Sergey Fedoseev
Status: new → assigned

comment:2 by Tim Graham, 8 years ago

Triage Stage: Unreviewed → Accepted

Maybe a name like CPointerBase?

comment:3 by Sergey Fedoseev, 8 years ago

CPointerBase looks better than my PtrBase.

comment:4 by Sergey Fedoseev, 8 years ago

Has patch: set

PR -- ​https://github.com/django/django/pull/5828

comment:5 by Tim Graham, 8 years ago

Triage Stage: Accepted → Ready for checkin

comment:6 by Tim Graham, 8 years ago

Patch needs improvement: set
Triage Stage: Ready for checkin → Accepted

comment:7 by Sergey Fedoseev, 7 years ago

Patch needs improvement: unset

​PR

comment:8 by Tim Graham <timograham@…>, 7 years ago

Resolution: → fixed
Status: assigned → closed

In b01ceae8:

Fixed #25938 -- Factored out CPointerBase base class for GEOSBase/GDALBase.

Note: See TracTickets for help on using tickets.
Back to Top