Opened 5 years ago

Closed 4 years ago

Last modified 2 years ago

#25809 closed New feature (fixed)

PostgreSQL 9.5 BRIN Index support in contrib.postgres

Reported by: Asif Saifuddin Auvi Owned by: Mads Jensen
Component: contrib.postgres Version: master
Severity: Normal Keywords: postgres, index, BRIN, db-indexes
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

pgsql 9.5 introduces BRIN index which will be nice to have in django postgres.

Change History (18)

comment:1 Changed 5 years ago by Tim Graham

Do you have a proposed API?

comment:2 in reply to:  1 Changed 5 years ago by Asif Saifuddin Auvi

Replying to timgraham:

Do you have a proposed API?

not till now, but should be based on Class based Index Dep?

comment:3 Changed 5 years ago by Tim Graham

Triage Stage: UnreviewedSomeday/Maybe

I'd guess so.

comment:4 Changed 4 years ago by Tim Graham

Triage Stage: Someday/MaybeAccepted

This can likely move forward now that the framework for class-based indexes is in master.

comment:5 in reply to:  4 Changed 4 years ago by Asif Saifuddin Auvi

Replying to timgraham:

This can likely move forward now that the framework for class-based indexes is in master.

exactly. will this be part of current gsoc?

Last edited 4 years ago by Asif Saifuddin Auvi (previous) (diff)

comment:6 Changed 4 years ago by Asif Saifuddin Auvi

Keywords: postgres index BRIN added

comment:7 Changed 4 years ago by Mads Jensen

Has patch: set
Patch needs improvement: set
Last edited 4 years ago by Tim Graham (previous) (diff)

comment:8 Changed 4 years ago by Mads Jensen

Owner: set to Mads Jensen
Status: newassigned

comment:9 Changed 4 years ago by Mads Jensen

Patch needs improvement: unset

Updated according to review by Tim Graham. It's tricky finding a good sql_create_index that suits all backends, as the current design requires. My solution just introduces a new one, and uses this in the as_sql-method.

Last edited 4 years ago by Mads Jensen (previous) (diff)

comment:10 Changed 4 years ago by Markus Holtermann

Triage Stage: AcceptedReady for checkin

comment:11 Changed 4 years ago by Mads Jensen <mje@…>

Resolution: fixed
Status: assignedclosed

In e585c43b:

Fixed #25809 -- Added BrinIndex support in django.contrib.postgres.

Thanks Tim Graham and Markus Holtermann for review.

comment:12 Changed 4 years ago by Akshesh Doshi

Keywords: db-indexes added

comment:13 Changed 4 years ago by Markus Holtermann <info@…>

In 7e299c0:

Refs #25809 -- Prefered imports from django.db.models.

comment:14 Changed 4 years ago by Tim Graham <timograham@…>

In 65e321b7:

Refs #25809 -- Made a few late review comments for BrinIndex.

comment:15 Changed 3 years ago by GitHub <noreply@…>

In d1d7348:

Refs #25809 -- Removed BrinIndex.repr().

In retrospect, implementing a repr() for index subclasses doesn't
seem worthwhile.

comment:16 Changed 3 years ago by Tim Graham <timograham@…>

In fb42d024:

Refs #25809 -- Omitted pages_per_range from BrinIndex.deconstruct() if it's None.

comment:17 Changed 3 years ago by Tim Graham <timograham@…>

In c685b8f8:

[1.11.x] Refs #25809 -- Omitted pages_per_range from BrinIndex.deconstruct() if it's None.

Backport of fb42d0247136249ea81962474e9a6a2faf1755f1 from master

comment:18 Changed 2 years ago by Tim Graham <timograham@…>

In ff9543b:

Refs #25809, #28990 -- Added PostgreSQL version check for BrinIndex support.

Note: See TracTickets for help on using tickets.
Back to Top