Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#25196 closed Bug (fixed)

Wrong db name in "Destroying old test database" message

Reported by: Ville Skyttä Owned by: Tim Graham <timograham@…>
Component: Database layer (models, ORM) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

The database name to be destroyed in the "Destroying old test database" message is incorrect.

Pull request at ​https://github.com/django/django/pull/5068

The oracle backend needs a fix too, it also outputs an incorrect db name but the problems in it don't apparently end there as there is some confusion in the messages where it says it's deleting a database but actually deletes a tablespace. So I'll leave fixing that to someone who actually knows what it's doing and can test it.

Change History (11)

comment:1 by Tim Graham, 10 years ago

Triage Stage: Unreviewed → Accepted

comment:2 by Tim Graham, 10 years ago

Patch needs improvement: set

comment:3 by Sambhav Satija, 10 years ago

Owner: changed from nobody to Sambhav Satija
Status: new → assigned

Taking it since it's getting stale.

comment:4 by Sambhav Satija, 10 years ago

Patch needs improvement: unset

PR: ​https://github.com/django/django/pull/5298

comment:5 by Tim Graham, 10 years ago

Patch needs improvement: set

The new pull request isn't correct.

comment:6 by Sambhav Satija, 10 years ago

Has patch: unset
Owner: Sambhav Satija removed
Patch needs improvement: unset
Status: assigned → new

Removing self.

comment:7 by Ville Skyttä, 10 years ago

Has patch: set

PR 5068 updated

comment:8 by Tim Graham <timograham@…>, 9 years ago

Owner: set to Tim Graham <timograham@…>
Resolution: → fixed
Status: new → closed

In afe7776:

Fixed #25196 -- Normalized database representations in test database messages.

Left over Oracle mostly as-is since it's more complicated.

comment:9 by Tim Graham <timograham@…>, 9 years ago

In 50ccedae:

[1.9.x] Fixed #25196 -- Normalized database representations in test database messages.

Left over Oracle mostly as-is since it's more complicated.

Backport of afe777639cc1c591df32591e196d4cda5783c615 from master

comment:10 by Tim Graham <timograham@…>, 9 years ago

In abcdb23:

Refs #25196 -- Fixed incorrect argument order in test database creation.

comment:11 by Tim Graham <timograham@…>, 9 years ago

In f0da306:

[1.9.x] Fixed #26096, refs #25196 -- Fixed incorrect argument order in test database creation.

Backport of abcdb237bb313d116ce2ac8e90f79f61429afc70 from master

Note: See TracTickets for help on using tickets.
Back to Top