Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#25196 closed Bug (fixed)

Wrong db name in "Destroying old test database" message

Reported by: Ville Skyttä Owned by: Tim Graham <timograham@…>
Component: Database layer (models, ORM) Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

The database name to be destroyed in the "Destroying old test database" message is incorrect.

Pull request at https://github.com/django/django/pull/5068

The oracle backend needs a fix too, it also outputs an incorrect db name but the problems in it don't apparently end there as there is some confusion in the messages where it says it's deleting a database but actually deletes a tablespace. So I'll leave fixing that to someone who actually knows what it's doing and can test it.

Change History (11)

comment:1 Changed 5 years ago by Tim Graham

Triage Stage: UnreviewedAccepted

comment:2 Changed 5 years ago by Tim Graham

Patch needs improvement: set

comment:3 Changed 5 years ago by Sambhav Satija

Owner: changed from nobody to Sambhav Satija
Status: newassigned

Taking it since it's getting stale.

comment:4 Changed 5 years ago by Sambhav Satija

Patch needs improvement: unset

comment:5 Changed 5 years ago by Tim Graham

Patch needs improvement: set

The new pull request isn't correct.

comment:6 Changed 5 years ago by Sambhav Satija

Has patch: unset
Owner: Sambhav Satija deleted
Patch needs improvement: unset
Status: assignednew

Removing self.

comment:7 Changed 5 years ago by Ville Skyttä

Has patch: set

PR 5068 updated

comment:8 Changed 5 years ago by Tim Graham <timograham@…>

Owner: set to Tim Graham <timograham@…>
Resolution: fixed
Status: newclosed

In afe7776:

Fixed #25196 -- Normalized database representations in test database messages.

Left over Oracle mostly as-is since it's more complicated.

comment:9 Changed 5 years ago by Tim Graham <timograham@…>

In 50ccedae:

[1.9.x] Fixed #25196 -- Normalized database representations in test database messages.

Left over Oracle mostly as-is since it's more complicated.

Backport of afe777639cc1c591df32591e196d4cda5783c615 from master

comment:10 Changed 5 years ago by Tim Graham <timograham@…>

In abcdb23:

Refs #25196 -- Fixed incorrect argument order in test database creation.

comment:11 Changed 5 years ago by Tim Graham <timograham@…>

In f0da306:

[1.9.x] Fixed #26096, refs #25196 -- Fixed incorrect argument order in test database creation.

Backport of abcdb237bb313d116ce2ac8e90f79f61429afc70 from master

Note: See TracTickets for help on using tickets.
Back to Top