Opened 9 years ago

Closed 9 years ago

#25117 closed Bug (fixed)

Update urlify.js with Romanian missing characters

Reported by: ionescu77 Owned by: ionescu77
Component: contrib.admin Version: dev
Severity: Normal Keywords: admin
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Hi,

after some reading, I think my issue seems to be similar to #5044 (latvian characters missing).

I have the same problem with romanian characters missing (slugify, urlify):

  • ă should be a
  • î should be i
  • ș should be s
  • ț should be t
  • â should be a

Right now the romanian characters get lost (for a slugfield when prepopulating from another field in admin) .

I am using Django version 1.7.1 on my laptop but I have checked the latest django branches on github and there is no ROMANIAN language entry in: django/django/contrib/admin/static/admin/js/urlify.js

I will try to do a pull request (I am kind of new to github). I am currently reading the how-to's on contributing/fixing.

Change History (8)

comment:1 by ionescu77, 9 years ago

Has patch: set
Needs tests: set

Hi,

following instructions I created a branch for this ticket on github with the added ROMANIAN_MAP:

https://github.com/ionescu77/django/tree/ticket_25117

I hope all is fine like this.

comment:2 by ionescu77, 9 years ago

Github Pull request 4990

I have tested locally and it works. I do not know where to write/include the unit tests.

Thx

comment:3 by ionescu77, 9 years ago

Type: Cleanup/optimizationBug

comment:4 by ionescu77, 9 years ago

Version: 1.8master

comment:5 by ionescu77, 9 years ago

Owner: changed from nobody to ionescu77
Status: newassigned

comment:6 by ionescu77, 9 years ago

Resolution: fixed
Status: assignedclosed

comment:7 by Tim Graham, 9 years ago

Needs tests: unset
Resolution: fixed
Status: closednew
Triage Stage: UnreviewedReady for checkin

Ticket isn't marked fixed until the patch is merged.

comment:8 by Tim Graham <timograham@…>, 9 years ago

Resolution: fixed
Status: newclosed

In 97bc8752:

Fixed #25117 -- Added Romanian char map for Javascript slug generation

Note: See TracTickets for help on using tickets.
Back to Top