Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#24729 closed Bug (fixed)

Test --keepdb option is incompatible with data migrations.

Reported by: acoady Owned by: nobody
Component: Database layer (models, ORM) Version: 1.8
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by acoady)

In 1.8 only, the test db is flushed before running migrations. But when using --keepdb the migrations won't be run, therefore any app which has data migrations will effectively be broken. For most non-trivial apps, their test setups won't even run.

In 1.9, this issue is already handled because flushing the test db has been removed anyway.

​https://github.com/django/django/pull/4582

Change History (4)

comment:1 by acoady, 9 years ago

Description: modified (diff)

comment:2 by Tim Graham, 9 years ago

Has patch: set
Triage Stage: Unreviewed → Ready for checkin
Type: Uncategorized → Bug

comment:3 by Tim Graham <timograham@…>, 9 years ago

Resolution: → fixed
Status: new → closed

In 6b05d3a:

[1.8.x] Fixed #24729 -- Removed test db flush when using --keepdb.

comment:4 by Sam Thompson, 7 years ago

This appears to also be broken in 1.9 (1.9.6 in my case). Investigating further before opening a new ticket.

Note: See TracTickets for help on using tickets.
Back to Top