Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#24729 closed Bug (fixed)

Test --keepdb option is incompatible with data migrations.

Reported by: acoady Owned by: nobody
Component: Database layer (models, ORM) Version: 1.8
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by acoady)

In 1.8 only, the test db is flushed before running migrations. But when using --keepdb the migrations won't be run, therefore any app which has data migrations will effectively be broken. For most non-trivial apps, their test setups won't even run.

In 1.9, this issue is already handled because flushing the test db has been removed anyway.

https://github.com/django/django/pull/4582

Change History (4)

comment:1 Changed 5 years ago by acoady

Description: modified (diff)

comment:2 Changed 5 years ago by Tim Graham

Has patch: set
Triage Stage: UnreviewedReady for checkin
Type: UncategorizedBug

comment:3 Changed 5 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: newclosed

In 6b05d3a:

[1.8.x] Fixed #24729 -- Removed test db flush when using --keepdb.

comment:4 Changed 3 years ago by Sam Thompson

This appears to also be broken in 1.9 (1.9.6 in my case). Investigating further before opening a new ticket.

Note: See TracTickets for help on using tickets.
Back to Top