#24728 closed Cleanup/optimization (fixed)
feedgenerator classes still use "mime_type" instead of "content_type"
| Reported by: | Charlie DeTar | Owned by: | Raphael Michel |
|---|---|---|---|
| Component: | contrib.syndication | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
The mimetype argument to HttpResponse and others was deprecated in v1.5 and removed in v1.7 in favor of content_type to be more semantically aligned with the HTTP header it represents. However, the feedgenerator classes django.utils.feedgenerator.RssFeed and django.utils.feedgenerator.Atom1Feed still use a mime_type attribute.
This leads to slightly ungainly semantics like:
response = HttpResponse(content_type=feed.mime_type)
Might be aesthetically nicer to make this more consistent by using content_type across the board.
Change History (7)
comment:1 Changed 7 years ago by
| Component: | Uncategorized → contrib.syndication |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
| Type: | Uncategorized → Cleanup/optimization |
| Version: | 1.8 → master |
comment:2 Changed 7 years ago by
| Owner: | changed from nobody to Raphael Michel |
|---|---|
| Status: | new → assigned |
comment:3 Changed 7 years ago by
I renamed the attributes and started the deprecation in this pull request: https://github.com/django/django/pull/4760
comment:4 Changed 7 years ago by
| Has patch: | set |
|---|
comment:5 Changed 7 years ago by
| Triage Stage: | Accepted → Ready for checkin |
|---|
Note: See
TracTickets for help on using
tickets.
Yes, but of course a deprecation of the current names is required. See Deprecating a Feature for a checklist of things to do when writing the patch.