feedgenerator classes still use "mime_type" instead of "content_type"
The mimetype
argument to HttpResponse
and others was deprecated in v1.5 and removed in v1.7 in favor of content_type
to be more semantically aligned with the HTTP header it represents. However, the feedgenerator classes django.utils.feedgenerator.RssFeed
and django.utils.feedgenerator.Atom1Feed
still use a mime_type
attribute.
This leads to slightly ungainly semantics like:
response = HttpResponse(content_type=feed.mime_type)
Might be aesthetically nicer to make this more consistent by using content_type
across the board.
Change History
(7)
Component: |
Uncategorized → contrib.syndication
|
Triage Stage: |
Unreviewed → Accepted
|
Type: |
Uncategorized → Cleanup/optimization
|
Version: |
1.8 → master
|
Owner: |
changed from nobody to Raphael Michel
|
Status: |
new → assigned
|
Triage Stage: |
Accepted → Ready for checkin
|
Resolution: |
→ fixed
|
Status: |
assigned → closed
|
Yes, but of course a deprecation of the current names is required. See Deprecating a Feature for a checklist of things to do when writing the patch.