#24427 closed Bug (fixed)
makemigrations --merge ignores --dry-run
Reported by: | Julian Wachholz | Owned by: | John Giannelos |
---|---|---|---|
Component: | Migrations | Version: | dev |
Severity: | Normal | Keywords: | migration, dry-run, merge |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | yes | UI/UX: | no |
Description
Running makemigrations --dry-run --merge
will still create a migration file.
Tested in 1.7.4 and latest master (3b966c2b73c420222d1524cda03c1a5626c90fe6
)
Change History (9)
comment:1 Changed 8 years ago by
Easy pickings: | set |
---|---|
Triage Stage: | Unreviewed → Accepted |
comment:2 Changed 8 years ago by
Owner: | changed from nobody to John Giannelos |
---|---|
Status: | new → assigned |
comment:3 Changed 8 years ago by
comment:4 Changed 8 years ago by
Has patch: | set |
---|
comment:5 Changed 8 years ago by
Thanks for the patch, johngian. Do you mind creating a pull-request?
comment:6 Changed 8 years ago by
Pull request opened here:
https://github.com/django/django/pull/4252
Note: See
TracTickets for help on using
tickets.
I pushed a branch with the fix and a couple of regression tests here:
https://github.com/johngian/django/tree/ticket_24427