Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#24427 closed Bug (fixed)

makemigrations --merge ignores --dry-run

Reported by: Julian Wachholz Owned by: John Giannelos
Component: Migrations Version: dev
Severity: Normal Keywords: migration, dry-run, merge
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

Running makemigrations --dry-run --merge will still create a migration file.

Tested in 1.7.4 and latest master (3b966c2b73c420222d1524cda03c1a5626c90fe6)

Change History (9)

comment:1 Changed 8 years ago by Markus Holtermann

Easy pickings: set
Triage Stage: Unreviewed → Accepted

comment:2 Changed 8 years ago by John Giannelos

Owner: changed from nobody to John Giannelos
Status: new → assigned

comment:3 Changed 8 years ago by John Giannelos

I pushed a branch with the fix and a couple of regression tests here:
​https://github.com/johngian/django/tree/ticket_24427

comment:4 Changed 8 years ago by John Giannelos

Has patch: set

comment:5 Changed 8 years ago by Markus Holtermann

Thanks for the patch, johngian. Do you mind ​creating a pull-request?

comment:6 Changed 8 years ago by John Giannelos

Pull request opened here:
​https://github.com/django/django/pull/4252

comment:7 Changed 8 years ago by Tim Graham <timograham@…>

Resolution: → fixed
Status: assigned → closed

In 8758a63:

Fixed #24427 -- Stopped writing migration files in dry run mode when merging.

Also added display of migration to stdout when verbosity=3.

comment:8 Changed 8 years ago by Tim Graham <timograham@…>

In e150bbd:

[1.8.x] Fixed #24427 -- Stopped writing migration files in dry run mode when merging.

Also added display of migration to stdout when verbosity=3.

Backport of 8758a63ddbbf7a2626bd84d50cfe83b477e8de0a from master

comment:9 Changed 8 years ago by Tim Graham <timograham@…>

In cb48e192:

[1.7.x] Fixed #24427 -- Stopped writing migration files in dry run mode when merging.

Also added display of migration to stdout when verbosity=3.

Backport of 8758a63ddbbf7a2626bd84d50cfe83b477e8de0a from master

Note: See TracTickets for help on using tickets.
Back to Top