Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#24426 closed Bug (fixed)

Admin actions panel is always hidden if show_full_result_count = False

Reported by: Никита Шультайс Owned by: Tim Graham
Component: contrib.admin Version: 1.8beta1
Severity: Release blocker Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

django.contrib.admin.views.main.py

        if self.model_admin.show_full_result_count:
            if self.get_filters_params() or self.params.get(SEARCH_VAR):
                full_result_count = self.root_queryset.count()
            else:
                full_result_count = result_count
        else:
            full_result_count = None

if show_full_result_count is False then full_result_count = None

self.show_full_result_count = self.model_admin.show_full_result_count
...
self.show_admin_actions = self.show_full_result_count or bool(full_result_count)

But show_full_result_count is False and bool(full_result_count) is also False
self.show_admin_actions is always hidden

Change History (5)

comment:1 Changed 7 years ago by Tim Graham

Severity: NormalRelease blocker
Triage Stage: UnreviewedAccepted
Type: UncategorizedBug

Release blocker since it's a bug in a new feature in 1.8 (ModelAdmin.show_full_result_count).

comment:2 Changed 7 years ago by Tim Graham

Owner: changed from nobody to Tim Graham
Status: newassigned

comment:3 Changed 7 years ago by Simon Charette

Has patch: set
Triage Stage: AcceptedReady for checkin

comment:4 Changed 7 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: assignedclosed

In 36a17be9f3cf6081f7e6f83fcfeae3d09ce8a72b:

Fixed #24426 -- Displayed admin actions panel when show_full_result_count=False.

comment:5 Changed 7 years ago by Tim Graham <timograham@…>

In 20bf3205027fe581b8f33cd98b164f16a801c813:

[1.8.x] Fixed #24426 -- Displayed admin actions panel when show_full_result_count=False.

Backport of 36a17be9f3cf6081f7e6f83fcfeae3d09ce8a72b from master

Note: See TracTickets for help on using tickets.
Back to Top