Combine i18n template tag tests
I was working on #25372 and noticed there isn't an obvious place to add extra tests. This is because the i18n
tag tests are currently split among i18n
and template_tests.syntax_tests.test_i18n
. I think these tests should be combined in one place or the other.
I propose the following:
1) Move the tag-related tests from i18n
into template_tests
2) Split template_tests.syntax_tests.test_i18n
into separate files for each tag (test_trans.py, test_blocktrans.py, etc.)
I think change 1 makes sense because template_tests
is also where we have tests for things like staticfiles, cache, etc. The timezone tags are the only outlier here.
Change 2 is a pattern we adopted when converting the filter tests to unit tests. I think it would be good for template tag tests to follow the same pattern.
Does this seem like the right grouping?
Change History
(16)
Triage Stage: |
Unreviewed → Accepted
|
Easy pickings: |
set
|
Summary: |
Combine i18n template tag tests? → Combine i18n template tag tests
|
Owner: |
changed from nobody to Aleksandr Sobolev
|
Status: |
new → assigned
|
Triage Stage: |
Accepted → Ready for checkin
|
Has patch: |
set
|
Triage Stage: |
Ready for checkin → Accepted
|
Patch needs improvement: |
set
|
Owner: |
Aleksandr Sobolev removed
|
Status: |
assigned → new
|
Owner: |
set to Andy Craze
|
Status: |
new → assigned
|
Patch needs improvement: |
unset
|
Patch needs improvement: |
set
|
Patch needs improvement: |
unset
|
Triage Stage: |
Accepted → Ready for checkin
|
Resolution: |
→ fixed
|
Status: |
assigned → closed
|
Sounds good to me.