Opened 3 years ago

Closed 3 years ago

#24322 closed Cleanup/optimization (wontfix)

Increase consistency in the app registry

Reported by: Aymeric Augustin Owned by: Aymeric Augustin
Component: Core (Other) Version: master
Severity: Normal Keywords: app-loading
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

As a follow-up to #21680, we should improve the implementation of the app registry to ensure that set(self.all_models) in set(self.app_configs).

Change History (4)

comment:1 Changed 3 years ago by Aymeric Augustin

Owner: changed from nobody to Aymeric Augustin
Status: newassigned

comment:2 Changed 3 years ago by Aymeric Augustin

Keywords: app-loading added

comment:3 Changed 3 years ago by Aymeric Augustin

It's tempting to replace Apps.all_models by the combination of Apps.app_configs and AppConfig.models but this isn't possible because of set_available_apps.

Indeed, if it's used to add an application temporarily, the AppConfig for this application will be thrown away in unset_installed_apps. If it's used again to add the same application, there's no way to know which models belong to this app, unless the list has been stored somewhere like Apps.all_models.

Last edited 3 years ago by Aymeric Augustin (previous) (diff)

comment:4 Changed 3 years ago by Aymeric Augustin

Resolution: wontfix
Status: assignedclosed

This ticket was just about simplifying the implementation, not about changing some behavior.

There's no obvious way to move it forwards.

Note: See TracTickets for help on using tickets.
Back to Top