Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#24152 closed Cleanup/optimization (fixed)

Deprecate GeoQuerySet aggregate methods

Reported by: Claude Paroz Owned by: nobody
Component: GIS Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

In the trend of making GeoQuerySet as similar to QuerySet as possible, I'd suggest to deprecate the GeoQuerySet aggregation methods, as GIS aggregates (Union, Extent, Extent3D, MakeLine, Collect) are already available and usable like any other Django aggregate.

Change History (8)

comment:1 by Claude Paroz, 10 years ago

Has patch: set
Needs documentation: set

​https://github.com/django/django/pull/3920
I've not updated the documentation yet. Should this deprecation happen in 1.8 or are we too late?

comment:2 by Tim Graham, 10 years ago

As it's not a new feature, I'm fine with it going in tomorrow.

comment:3 by Claude Paroz <claude@…>, 10 years ago

In a34fba5e596a3ec95bf284fd77b1609e71a65019:

Simplified a bit GeoAggregate classes

Thanks Josh Smeaton for the review. Refs #24152.

comment:4 by Tim Graham, 10 years ago

Needs documentation: unset
Triage Stage: Accepted → Ready for checkin

comment:5 by Claude Paroz <claude@…>, 10 years ago

Resolution: → fixed
Status: new → closed

In a79e6b67175f532049967268c10609af6d31d140:

Fixed #24152 -- Deprecated GeoQuerySet aggregate methods

Thanks Josh Smeaton and Tim Graham for the reviews.

comment:6 by Tim Graham <timograham@…>, 10 years ago

In a8eb715:

Refs #24152 -- Fixed typos in deprecated GeoQuerySet aggregate names.

comment:7 by Tim Graham <timograham@…>, 10 years ago

In 6acf0df8:

[1.8.x] Refs #24152 -- Fixed typos in deprecated GeoQuerySet aggregate names.

Backport of a8eb715b663ff836e54f04c0e4fcafa2ee468b4e from master

comment:8 by Tim Graham <timograham@…>, 10 years ago

In 5d38354:

Refs #24152 -- Removed deprecated GeoQuerySet aggregate methods.

Per deprecation timeline.

Note: See TracTickets for help on using tickets.
Back to Top