Opened 10 years ago

Closed 10 years ago

#24151 closed Bug (duplicate)

GeoAggregate.prepare is never called

Reported by: Claude Paroz Owned by: nobody
Component: GIS Version: 1.8alpha1
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

GeoAggregate.prepare has been added in f59fd15c4928caf3dfcbd50f6ab47be409a43b01, however it is apparently never called from anywhere. Josh, an idea?

Change History (3)

in reply to:  description comment:1 by Josh Smeaton, 10 years ago

Replying to claudep:

GeoAggregate.prepare has been added in f59fd15c4928caf3dfcbd50f6ab47be409a43b01, however it is apparently never called from anywhere. Josh, an idea?

Yes, that should be resolve_expression now. It must have been overlooked when we changed the name of the method. It obviously needs a test too if none of the existing tests failed.

Last edited 10 years ago by Josh Smeaton (previous) (diff)

comment:2 by Claude Paroz, 10 years ago

In the patch for #24152 (​https://github.com/django/django/pull/3920) I've moved that check in check_spatial_aggregate. If you think this is an acceptable resolution, feel free to close this ticket.

comment:3 by Josh Smeaton, 10 years ago

Resolution: → duplicate
Status: new → closed
Note: See TracTickets for help on using tickets.
Back to Top