Opened 8 years ago

Closed 8 years ago

#24147 closed Bug (fixed)

Model managers in migration leak referenced model across project states

Reported by: Markus Holtermann Owned by: Markus Holtermann
Component: Migrations Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

When including model managers in migration the manager instances are shared across project states. Since a manager itself has a reference to a model the referenced model always refers to the latest rendered state which likely does not refer to the correct model.

Change History (4)

comment:1 Changed 8 years ago by Markus Holtermann

Has patch: set

​https://github.com/django/django/pull/3913

comment:2 Changed 8 years ago by Markus Holtermann

Owner: changed from Markus to Markus Holtermann
Status: new → assigned

comment:3 Changed 8 years ago by Tim Graham

Component: Uncategorized → Migrations
Triage Stage: Unreviewed → Ready for checkin
Version: 1.8alpha1 → master

comment:4 Changed 8 years ago by Markus Holtermann <info@…>

Resolution: → fixed
Status: assigned → closed

In 88786afbffc5c095f6491e080afea394f63bb44a:

Fixed #24147 -- Prevented managers leaking model during migrations

Thanks Tim Graham for the review.

Note: See TracTickets for help on using tickets.
Back to Top