Opened 8 years ago

Closed 7 years ago

#24116 closed Cleanup/optimization (fixed)

Refactor AdminSite.check_dependencies with the checks framework

Reported by: Aymeric Augustin Owned by: Vincenzo Pandolfo
Component: contrib.admin Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description (last modified by Aymeric Augustin)

The title says it all.

This ticket should also consider improving or dropping the check for the auth context processor. Currently it's skipped when there isn't exactly one Django templates engine configured in TEMPLATES. This could be improved. It doesn't account for the possibility that a developer will provide their own customized version. This is intractable.

Change History (10)

comment:1 Changed 8 years ago by Aymeric Augustin

Description: modified (diff)

comment:2 Changed 8 years ago by Tim Graham

Triage Stage: Unreviewed → Accepted

comment:3 Changed 7 years ago by Tim Graham

Easy pickings: set

Another problem from duplicate ticket #25877, "It runs as a side effect of loading the admin URLs. If it must run when Django starts it should be called from AdminAppConfig.ready() instead."

comment:4 Changed 7 years ago by Vincenzo Pandolfo

Owner: changed from nobody to Vincenzo Pandolfo
Status: new → assigned

comment:5 Changed 7 years ago by Vincenzo Pandolfo

Pull: ​https://github.com/django/django/pull/5816

Last edited 7 years ago by Tim Graham (previous) (diff)

comment:6 Changed 7 years ago by Tim Graham

Has patch: set
Needs documentation: set
Needs tests: set

Ideally we could also add some tests for this and documentation in docs/ref/checks.txt.

comment:8 Changed 7 years ago by Tim Graham

Needs documentation: unset
Needs tests: unset

comment:9 Changed 7 years ago by Tim Graham

Patch needs improvement: set

Left a round of review comments. Please uncheck "Patch needs improvement" after it's updated.

comment:10 Changed 7 years ago by Vincenzo Pandolfo

Patch needs improvement: unset

comment:11 Changed 7 years ago by Tim Graham <timograham@…>

Resolution: → fixed
Status: assigned → closed

In 0490d72:

Fixed #24116 -- Moved AdminSite.check_dependencies() to system checks.

Note: See TracTickets for help on using tickets.
Back to Top