#24000 closed Bug (fixed)
create_default_site 'db' kwarg should be 'using'
| Reported by: | tkhyn | Owned by: | Tim Graham |
|---|---|---|---|
| Component: | contrib.sites | Version: | 1.7 |
| Severity: | Release blocker | Keywords: | sites multidb |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description (last modified by )
Almost a non-bug as it only prevents the creation of the 'example.com' entry in the django_site table when this table does not lie in the default database (in case of a multi-db setup).
As the post_migrate signal uses the keyword using, it is indeed not picked up by create_default_site which uses db.
Trivial patch attached.
Attachments (1)
Change History (8)
Changed 8 years ago by
| Attachment: | create_default_site_patch.patch added |
|---|
comment:1 Changed 8 years ago by
| Description: | modified (diff) |
|---|
comment:2 Changed 8 years ago by
| Needs tests: | set |
|---|---|
| Patch needs improvement: | set |
| Triage Stage: | Unreviewed → Accepted |
comment:3 Changed 8 years ago by
| Severity: | Normal → Release blocker |
|---|
comment:4 Changed 8 years ago by
| Owner: | changed from nobody to Tim Graham |
|---|---|
| Status: | new → assigned |
| Version: | master → 1.7 |
comment:5 Changed 8 years ago by
| Needs tests: | unset |
|---|---|
| Patch needs improvement: | unset |
| Triage Stage: | Accepted → Ready for checkin |
Actually, it doesn't seem that a backwards compatibility shim is required.
comment:6 Changed 8 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
I think we need a backwards compatibility shim to check
dbas well since that's used by thepost_syncdbsignal. Could you also add a regression test?