create_default_site 'db' kwarg should be 'using'
Almost a non-bug as it only prevents the creation of the 'example.com' entry in the django_site
table when this table does not lie in the default database (in case of a multi-db setup).
As the post_migrate signal uses the keyword using
, it is indeed not picked up by create_default_site
which uses db
.
Trivial patch attached.
Description: |
modified (diff)
|
Needs tests: |
set
|
Patch needs improvement: |
set
|
Triage Stage: |
Unreviewed → Accepted
|
Severity: |
Normal → Release blocker
|
Owner: |
changed from nobody to Tim Graham
|
Status: |
new → assigned
|
Version: |
master → 1.7
|
Needs tests: |
unset
|
Patch needs improvement: |
unset
|
Triage Stage: |
Accepted → Ready for checkin
|
Resolution: |
→ fixed
|
Status: |
assigned → closed
|
I think we need a backwards compatibility shim to check
db
as well since that's used by thepost_syncdb
signal. Could you also add a regression test?