Default admin login.html form doesn't respect custom AuthenticationForm Media assets.

[Sveder]

If you replace the admin AuthenticationForm with a custom one and add form assets as described in ​https://docs.djangoproject.com/en/1.7/topics/forms/media/ (using the media class), it won't be reflected in the application. The root cause is that the admin/login.html template doesn't have the line {{form.media}} anywhere.

Adding that line fixes this.

[Berker Peksag]

How did you replace the admin authentication form? If you replace it by overriding AdminSite.login_form, you can also override the AdminSite.login_template attribute and set your custom login template path.

[Tim Graham]

I think it's reasonable if {{ form.media }} is included in the template by default (although there is a possibility the Media class will be deprecated at some point in favor of some other hook, see #22298).

[Sveder]

Replying to timgraham:

I think it's reasonable if {{ form.media }} is included in the template by default (although there is a possibility the Media class will be deprecated at some point in favor of some other hook, see #22298).

Thanks for the reply. It is such a small fix that it is worth doing even though Media might be deprecated. I'll submit a patch before the weekend is over.

[Sveder]

Replying to berkerpeksag:

How did you replace the admin authentication form? If you replace it by overriding AdminSite.login_form, you can also override the AdminSite.login_template attribute and set your custom login template path.

That is indeed the workaround but it's not a good solution as you need to keep updating your new "custom" login html with whatever changes happen in Django. I think the idiomatic way to do it (for now) is using Media, and it should work as expected. Thank you for noting the workaround though, in case other people stumble over this.

[arcturusannamalai]

@Sveder - I guess you should assign this ticket to yourself, since the solution is part of the problem description. Good work :-)

[David A Krauth]

Pull request ​https://github.com/django/django/pull/4257

[Erik Romijn <eromijn@…>]

In 88c605e3e34cebd5485d286a17ac84c7b8b0faf1:

Fixed #23993 -- Added form.media to the admin login template.