Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#23992 closed Cleanup/optimization (fixed)

DiscoverRunner.build_suite() is slow

Reported by: Thomas C Owned by: nobody
Component: Testing framework Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The current implementation of DiscoverRunner.build_suite() is slow (it takes 30s+ on my machine when running the full Django test suite). This time is mostly spent on the partition_suite() function.

Change History (3)

comment:1 by Claude Paroz, 9 years ago

Triage Stage: Unreviewed → Ready for checkin

Wow, passing from 22/23 secs to 0.04 secs, amazing.

comment:2 by Thomas Chaumeny <t.chaumeny@…>, 9 years ago

Resolution: → fixed
Status: new → closed

In 2ca0870b672413cf5bc6e441bda58839f902f5b0:

Fixed #23992 -- Optimized reorder_suite functions using OrderedSet

comment:3 by Aymeric Augustin <aymeric.augustin@…>, 9 years ago

In 0fc188251069b73b293f79dba6f3e9e331ad7e91:

Merge pull request #3730 from tchaumeny/test_suite_reorder

Fixed #23992 -- Optimized reorder_suite functions using OrderedSet

Note: See TracTickets for help on using tickets.
Back to Top