Opened 9 years ago
Closed 9 years ago
#23948 closed New feature (fixed)
Password handling page templates should use Form's help_text not hardcoded value
| Reported by: | James McMahon | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.auth | Version: | dev |
| Severity: | Normal | Keywords: | help, password, form |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | yes |
| Easy pickings: | yes | UI/UX: | yes |
Description (last modified by )
Password set and change forms in the admin display hardcoded help text, despite using a Form object for some of the page (e.g. input). They should use the help_text specified on the field in the form definition (e.g. to support easy inclusion of password strength requirement help text). The current hardcoded values can be set as the default on the forms used if they are not replaced.
Patch demonstrating request attached
Attachments (2)
Change History (6)
by , 9 years ago
| Attachment: | password_help.patch added |
|---|
comment:1 by , 9 years ago
| Description: | modified (diff) |
|---|
comment:2 by , 9 years ago
| Has patch: | set |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
| Version: | 1.7 → master |
comment:3 by , 9 years ago
| Patch needs improvement: | set |
|---|
I think we should avoid outputting an empty <p class="help"></p> if there's no help text.
by , 9 years ago
| Attachment: | password_help_improved.patch added |
|---|
Last patch had a syntax error(an unclosed bracket). Fixed that and only showing help_text <p> tag if a help_text is available.
comment:4 by , 9 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
patch which acheives the described behaviour