Opened 10 years ago

Closed 10 years ago

#23923 closed Cleanup/optimization (fixed)

Promote Django's deprecation warnings to errors in runtests.py

Reported by: Tim Graham Owned by: nobody
Component: Testing framework Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The Django test suite should run without any visible deprecation warnings.

By changing:

warnings.simplefilter("default", RemovedInDjango19Warning)
warnings.simplefilter("default", RemovedInDjango20Warning)

to:

warnings.simplefilter("error", RemovedInDjango19Warning)
warnings.simplefilter("error", RemovedInDjango20Warning)

in runtests.py we can have Jenkins (which runs with -Wall) fail builds that introduce unsilenced deprecation warnings. This will save us time from having to track them down after the fact.

Change History (3)

comment:1 by Simon Charette, 10 years ago

Triage Stage: Unreviewed → Accepted

comment:2 by Tim Graham, 10 years ago

Has patch: set

​PR is ready for review.

comment:3 by Tim Graham <timograham@…>, 10 years ago

Resolution: → fixed
Status: new → closed

In 3131e9cef5f0a96f4fe667b0b1626c238153d1f1:

Fixed #23923 -- Promoted Django's deprecation warnings to errors in runtests.py

Note: See TracTickets for help on using tickets.
Back to Top