Quoting problem in RequestFactory

[Berker Peksag]

I was trying to convert middleware tests to use RequestFactory. I've converted all tests easily except CommonMiddlewareTest.test_append_slash_quoted:

    @override_settings(APPEND_SLASH=True)
    def test_append_slash_quoted(self):
        """
        Tests that URLs which require quoting are redirected to their slash
        version ok.
        """
        request = self._get_request('needsquoting#')
        r = CommonMiddleware().process_request(request)
        self.assertEqual(r.status_code, 301)
        self.assertEqual(
            r.url,
            'http://testserver/needsquoting%23/')

​https://github.com/django/django/blob/master/tests/middleware/tests.py#L94

The urlparse call in the RequestFactory.generic method swallows # in the URL. The test is passing with a plain HttpRequest object.

Here is a try to fix this problem: ​https://github.com/berkerpeksag/django/compare/use-requestfactory

An alternative fix would be to wrap path with quote(path, safe=b"...") or with django.utils.encoding.escape_uri_path in RequestFactory.generic:

​https://github.com/django/django/blob/master/django/test/client.py#L351

[Berker Peksag]

​https://github.com/django/django/pull/3645

[Tim Graham]

Question about the implementation left on the PR.

[Tim Graham]

On further investigation, I think we can simply use the urlencoded version of # when updating that test to use RequestFactory like this: rf.get('/needsquoting%23'). The test passes and works as a regression test as originally intended if I remove urlquote from urlquote(new_url[1]) in CommonMiddleware.

[Berker Peksag]

Thanks. I agree with your analysis. I'll convert my branch to a pull request and will close ​PR #3645.