Opened 9 years ago

Closed 9 years ago

#23840 closed Bug (fixed)

Confusing message from makemessages

Reported by: Takis Issaris Owned by: Ilja Maas
Component: Internationalization Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

When there's no locale dir available to store the gettext related messages the makemessages command complains with the following message:
CommandError: Unable to find a locale path to store translations for file db.sqlite3

If found the message rather confusing due to the messages referring to the database file, implying that something was going wrong and it was trying to find translatable strings in the sqlite database file.

Maybe it would be better if the filename wouldn't be mentioned?

Attachments (2)

makemessages.diff​ (2.6 KB ) - added by Ilja Maas 9 years ago.
23840-test.diff​ (1.1 KB ) - added by Claude Paroz 9 years ago.
Failing test

Download all attachments as: .zip

Change History (10)

comment:1 by Claude Paroz, 9 years ago

Triage Stage: Unreviewed → Accepted

Confirmed, we should definitely skip files with unrecognized extensions sooner in the process, in find_files.

by Ilja Maas, 9 years ago

Attachment: makemessages.diff​ added

comment:2 by Ilja Maas, 9 years ago

Owner: changed from nobody to Ilja Maas
Status: new → assigned

While looking into patching this I found out some IMHO strange behaviour.

If no --extension or --domain is provided makemessages claims to be handling .txt and .html files ( via --verbosity=2 )

That is not really true as it is also handling all .py files.
Actually forcing --extension=html also gets the .py files handled

My patch changes this back to actually only handling the extensions specified or .html .txt and .py if nothing is specified.

After patching, the find_files routine skips all unwanted/unknown extensions, even before diving into the TranslatableFiles fixing the confusing messages for unhandled extensions

Note: As far as I can see there a no unittest covering this part.

Last edited 9 years ago by Ilja Maas (previous) (diff)

comment:3 by Claude Paroz, 9 years ago

Has patch: set
Needs tests: set

comment:4 by Ilja Maas, 9 years ago

@claudep Do you expect this to get covered by unittests somehow?

by Claude Paroz, 9 years ago

Attachment: 23840-test.diff​ added

Failing test

comment:5 by Claude Paroz, 9 years ago

I've attached a (possible) failing test that should be fixed by the patch (I didn't verify this).
@iljamaas Are you interested in creating a pull request on Github for this ticket (combining both test and fix)?

comment:6 by Ilja Maas, 9 years ago

@claudep I will make a git pullrequest with fix+test!

comment:8 by Claude Paroz <claude@…>, 9 years ago

Resolution: → fixed
Status: assigned → closed

In bb4a92d7845878b2ce0c4a5ca154cb4db22f7bad:

Fixed #23840 -- Fixed makemessages find_files method

Changed the handling of extensions to be used for gettext. Now
obeying the --extension argument. find_files now only find the
given or default extensions and puts only these in the
TranslatableFiles. As a result there are no more confusing messages
for filetypes (extension) not handled by makemessages.

Note: See TracTickets for help on using tickets.
Back to Top