Opened 10 years ago

Closed 10 years ago

#23701 closed Cleanup/optimization (fixed)

Removing an unneeded check in collectstatic

Reported by: Prathik Rajendran M Owned by: nobody
Component: contrib.staticfiles Version: 1.7
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


The copy_file function in seems to have a check in the end to see whether a prefixed_path is already in self.copied_files array but this check appears to be unnecessary as if it is in the code would return at the start with a message saying already copied.

I am new to this, as far as I could get from the documentation I should create a ticket here and then post a pull request to django? Please advise if this is not the proces. Here is the pull request:

Also it is a very minor change.

Change History (2)

comment:1 by Tim Graham, 10 years ago

Summary: Removing an unwanted check in collectstaticRemoving an unneeded check in collectstatic
Triage Stage: UnreviewedReady for checkin

Yes, you have the process mostly correct. Each fix should be in a separate pull request, but I think you knew that. There is a "Working with Git" section in the
contributing guide that should help with that. You'll also find the patch review checklist helpful. I'm going to write a proper commit message (see the checklist for the format) and commit this change.

comment:2 by Tim Graham <timograham@…>, 10 years ago

Resolution: fixed
Status: newclosed

In 36ea03eb36b4d4248e2bec0bb97328f2a1fd794e:

Fixed #23701 -- Removed an unneeded check in collectstatic.

Thanks prathik for the report.

Note: See TracTickets for help on using tickets.
Back to Top