Docs for Rendering fields manually <label for="...."> showing static rather than dynamic code

[awidgery]

See here:

​https://docs.djangoproject.com/en/1.7/topics/forms/#rendering-fields-manually

<div class="fieldWrapper">
    {{ form.subject.errors }}
    <label for="id_subject">Email subject:</label>
    {{ form.subject }}
</div>

Wouldn't it be better to show:

<div class="fieldWrapper">
    {{ form.subject.errors }}
    <label for="{{ form.subject.id_for_label }}">Email subject:</label>
    {{ form.subject }}
</div>

[Tim Graham]

That seems fine to me. In the ticket you original had auto_id, but I think you meant id_for_label so I edited the description. We might also want to note the alternative of {{ field.label_tag }} for that entire line, presuming you have made all the customizations on the form.

[Neven Munđar]

I've made a PR here: ​https://github.com/django/django/pull/3524

[Berker Peksag]

​PR #3524 LGTM.

[nmundar <neven.mundar@…>]

In 48515ee1f7bec437544a0a958332483298f4028b:

Fixed #23690 - fixed examples of manual rendering of form fields

Documentation for rendering form fields manually is now updated to use fields id_for_label instead of hardcoded values with additional mention of label_tag for alternative generation of complete label tag.

[Marc Tamlyn <marc.tamlyn@…>]

In d30a131119c34ba166ccb7b01bc6201caa6f0831:

Merge pull request #3524 from nmundar/ticket_23690

Fixed #23690 - fixed examples of manual rendering of form fields

[Tim Graham <timograham@…>]

In b2534bfa7b3b4f9d5e6c4db48556d2ae6ba3b4a9:

[1.7.x] Fixed #23690 - fixed examples of manual rendering of form fields

Documentation for rendering form fields manually is now updated to use fields id_for_label instead of hardcoded values with additional mention of label_tag for alternative generation of complete label tag.

Backport of 48515ee1f7bec437544a0a958332483298f4028b from master