Opened 6 years ago

Closed 6 years ago

#23573 closed Cleanup/optimization (duplicate)

Should tutorial 2 demonstrate AdminSite.site_header instead of overriding templates?

Reported by: hernandocounty Owned by: nobody
Component: Documentation Version: 1.7
Severity: Normal Keywords:
Cc: hernandocounty Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Aymeric Augustin)

Tutorial 2 shows how to change the admin's header (see also #21378).

However, in Django 1.7, there's a better way to achieve this particular task: AdminSite.site_header.

If that example is intended to demonstrate how to override a template, then it should tackle another use case for which overriding templates is the simplest choice.

If it is intended to show how to customize the admin's header, then it should describe the simplest solution.

Change History (5)

comment:1 Changed 6 years ago by hernandocounty

Cc: hernandocounty added
Needs documentation: set

comment:2 Changed 6 years ago by Claude Paroz

Resolution: invalid
Status: newclosed

With such language, you are not going to go very far. If you really want to make a constructive contribution to the Django project, which is run through volunteers, please reopen a new ticket, change your language and describe politely what you are suggesting to improve in the Django documentation. Or just use another framework with better documentation.

comment:3 Changed 6 years ago by hernandocounty

Description: modified (diff)

comment:4 Changed 6 years ago by Aymeric Augustin

Component: Template systemDocumentation
Description: modified (diff)
Keywords: TEMPLATES_DIR removed
Needs documentation: unset
Resolution: invalid
Status: closednew
Summary: Templates override with Admin Site TEMPLATE_DIRS wrong wayShould tutorial 2 demonstrate AdminSite.site_header instead of overriding templates?
Triage Stage: UnreviewedAccepted

I've rewritten the ticket because the state of the reporter's ass is only marginally relevant to the Django project ;-) However, the idea is valid.

comment:5 Changed 6 years ago by Aymeric Augustin

Resolution: duplicate
Status: newclosed

Mmm, in fact the discussion reached the same point in #23575 (unless I missed something).

Note: See TracTickets for help on using tickets.
Back to Top