Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#23529 closed Cleanup/optimization (fixed)

Template docs shouldn't use comments as an example

Reported by: Aymeric Augustin Owned by: Ola Sitarska
Component: Documentation Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

The example is here: https://docs.djangoproject.com/en/1.7/topics/templates/#custom-tag-and-filter-libraries

But the django.contrib.comments app was removed from Django. I suggest using another example.

The following contrib apps provide template tags: admin, flatpages, humanize, staticfiles, webdesign.

Change History (9)

comment:1 by Baptiste Mispelon, 10 years ago

Easy pickings: set
Triage Stage: UnreviewedAccepted

Good catch.

comment:2 by Varun Sharma, 10 years ago

Can we replace this with an example from django.contrib.humanize ?

comment:3 by Aymeric Augustin, 10 years ago

Yes, that's a good choice. Would you like to write a patch?

comment:4 by Ola Sitarska, 10 years ago

Owner: changed from nobody to Ola Sitarska
Status: newassigned

comment:6 by Baptiste Mispelon <bmispelon@…>, 10 years ago

Resolution: fixed
Status: assignedclosed

In ee442e97da390b7136dc12b66ddfa70263a60b5c:

Fixed #23529 -- Replaced comments tag library with humanize in docs

comment:7 by Baptiste Mispelon <bmispelon@…>, 10 years ago

In 02b3a6dcc0aef39f9174d4ac7a70679161de0962:

[1.7.x] Fixed #23529 -- Replaced comments tag library with humanize in docs

Backport of ee442e97da390b7136dc12b66ddfa70263a60b5c from master.

comment:8 by Baptiste Mispelon <bmispelon@…>, 10 years ago

In a6c294a5a293b1096e4e8dd86933c76356c70d71:

[1.6.x] Fixed #23529 -- Replaced comments tag library with humanize in docs

Backport of ee442e97da390b7136dc12b66ddfa70263a60b5c from master.

in reply to:  3 comment:9 by Varun Sharma, 10 years ago

Replying to aaugustin:

Yes, that's a good choice. Would you like to write a patch?

Yes, I would love to but I didn't know things move that fast in here :)

Note: See TracTickets for help on using tickets.
Back to Top