#23504 closed Bug (fixed)
Oracle GIS test failures
Reported by: | Tim Graham | Owned by: | Tim Graham |
---|---|---|---|
Component: | GIS | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Accepted | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
As we haven't had this build on Jenkins for a while (ever?), there are quite a few test failures that need fixing.
Change History (23)
comment:1 by , 10 years ago
comment:16 by , 10 years ago
The remaining failures are:
- Claude suggested trying a zip with a smaller area, but there are still discrepancies between what Oracle and the other DBs calculate. This test only ran on PostGIS in <1.7.
====================================================================== FAIL: test06_geography_area (django.contrib.gis.tests.geogapp.tests.GeographyTest) Testing that Area calculations work on geography columns. ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/tim/code/django/django/test/testcases.py", line 968, in skip_wrapper return test_func(*args, **kwargs) File "/home/tim/code/django/django/contrib/gis/tests/geogapp/tests.py", line 102, in test06_geography_area self.assertAlmostEqual(z.area.sq_m, ref_area, tol) AssertionError: 5439100.95415646 != 5439084.70637573 within 5 places
- Can be made to pass with the diff the follows, but may more investigation and/or just skipped on Oracle.
====================================================================== FAIL: test_unionagg (django.contrib.gis.tests.geoapp.tests.GeoQuerySetTest) Testing the `unionagg` (aggregate union) GeoQuerySet method. ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/tim/code/django/django/test/testcases.py", line 968, in skip_wrapper return test_func(*args, **kwargs) File "/home/tim/code/django/django/contrib/gis/tests/geoapp/tests.py", line 751, in test_unionagg self.assertEqual(True, union1.equals_exact(u1, tol) or union2.equals_exact(u1, tol)) AssertionError: True != False
diff --git a/django/contrib/gis/tests/geoapp/tests.py b/django/contrib/gis/tests/geoapp/tests.py index f4699ae..306664b 100644 --- a/django/contrib/gis/tests/geoapp/tests.py +++ b/django/contrib/gis/tests/geoapp/tests.py @@ -791,6 +791,8 @@ class GeoQuerySetTest(TestCase): # Houston, Dallas -- Ordering may differ depending on backend or GEOS version. union1 = fromstr('MULTIPOINT(-96.801611 32.782057,-95.363151 29.763374)') union2 = fromstr('MULTIPOINT(-95.363151 29.763374,-96.801611 32.782057)') + if oracle: + union1 = union2 = fromstr('POINT (-97.5211570000000023 34.4646419999999978)') qs = City.objects.filter(point__within=tx) self.assertRaises(TypeError, qs.unionagg, 'name') # Using `field_name` keyword argument in one query and specifying an
- Fixed in #23537.
====================================================================== FAIL: test_add_gis_field (django.contrib.gis.tests.gis_migrations.test_operations.OperationTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/tim/code/django/django/contrib/gis/tests/gis_migrations/test_operations.py", line 73, in test_add_gis_field 2 AssertionError: 0 != 2
comment:17 by , 10 years ago
For 1., I think we will not avoid using a specific value for Oracle.
For 2., unless we understand what's happening, it should be marked as an expectedFailure on Oracle. Some Oracle lover will hopefully chime in and fix it.
comment:22 by , 10 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Oracle GIS tests are passing and have been added to Jenkins.
Note:
See TracTickets
for help on using tickets.
Below are the failures from 89559bcfb096ccc625e0e9ab41e2136fcb32a514 (right before e9103402c0fa873aea58a6a11dba510cd308cb84#diff-54b46d05e1da568b3cc987c423e00c50L253 which broke a bunch more with errors like:
I guess it's because this logic was lost https://github.com/django/django/commit/e9103402c0fa873aea58a6a11dba510cd308cb84#diff-54b46d05e1da568b3cc987c423e00c50L253 on GIS fields.