Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#23417 closed Cleanup/optimization (fixed)

Added/completed zh and zh_CN locale format.py files

Reported by: Malte Beckmann Owned by: nobody
Component: Translations Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Malte Beckmann)

I noticed Chinese date formatting wasn't working. So I quickly completed zh_CN but also added a generic zh locale. Both contain the same formatting. I am Chinese speaking and did check that there are no mistakes.

# Addition 1: This is my first contribution and I am opening this ticket to get a ticket ID for pushing my additions/changes via git.
# Addition 2: Ok, finally managed to get it out: https://github.com/maltebeckmann/django/compare/ticket_23417?expand=1

Change History (6)

comment:1 Changed 3 years ago by Malte Beckmann

Description: modified (diff)

comment:2 Changed 3 years ago by Tim Graham

Easy pickings: unset
Has patch: set
Triage Stage: UnreviewedAccepted
Type: UncategorizedCleanup/optimization
Version: 1.6master

I created a PR from your branch for review purposes. As we have no Chinese speakers on the cored team as far as I know, could you find a colleague to review the changes and mark the ticket "Ready for Checkin" if it looks okay?

As for the translations, have you simply fetched them from Transifex?

comment:3 Changed 3 years ago by Claude Paroz

I think there are two distinct issues here.
Firstly, Chinese formats.py need to be completed, that's for sure.

But I'm not sure about the addition of the plain zh language code. I'm no Chinese expert, but on various projects I worked on, I never saw that. I think you'll need to develop a bit your rationales.

comment:4 Changed 3 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: newclosed

In 1ac32e76ac14323eef70142f57b8d7a3a192a829:

Fixed #23417 -- Completed locale formats for zh_CN, zh_Hans, zh_Hant and zh_TW.

comment:5 Changed 3 years ago by Tim Graham <timograham@…>

In 023a3d99156b458e0a8b0cb039aeca485066be07:

Updated release notes for backporting locale additions; refs #23368 and #23417.

comment:6 Changed 3 years ago by Tim Graham <timograham@…>

In d4c68c46aacbb151034baa321efe3d104e489e29:

[1.7.x] Fixed #23417 -- Completed locale formats for zh_CN, zh_Hans, zh_Hant and zh_TW.

Backport of 1ac32e76ac from master

Note: See TracTickets for help on using tickets.
Back to Top