#23417 closed Cleanup/optimization (fixed)
Added/completed zh and zh_CN locale format.py files
| Reported by: | Malte Beckmann | Owned by: | nobody |
|---|---|---|---|
| Component: | Translations | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
I noticed Chinese date formatting wasn't working. So I quickly completed zh_CN but also added a generic zh locale. Both contain the same formatting. I am Chinese speaking and did check that there are no mistakes.
# Addition 1: This is my first contribution and I am opening this ticket to get a ticket ID for pushing my additions/changes via git.
# Addition 2: Ok, finally managed to get it out: https://github.com/maltebeckmann/django/compare/ticket_23417?expand=1
Change History (6)
comment:1 by , 10 years ago
| Description: | modified (diff) |
|---|
comment:2 by , 10 years ago
| Easy pickings: | unset |
|---|---|
| Has patch: | set |
| Triage Stage: | Unreviewed → Accepted |
| Type: | Uncategorized → Cleanup/optimization |
| Version: | 1.6 → master |
comment:3 by , 10 years ago
I think there are two distinct issues here.
Firstly, Chinese formats.py need to be completed, that's for sure.
But I'm not sure about the addition of the plain zh language code. I'm no Chinese expert, but on various projects I worked on, I never saw that. I think you'll need to develop a bit your rationales.
comment:4 by , 10 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
I created a PR from your branch for review purposes. As we have no Chinese speakers on the cored team as far as I know, could you find a colleague to review the changes and mark the ticket "Ready for Checkin" if it looks okay?
As for the translations, have you simply fetched them from Transifex?