Opened 10 months ago

Closed 10 months ago

Last modified 10 months ago

#23380 closed Bug (fixed)

Transient failure of admin_filters.tests.ListFiltersTests.test_relatedfieldlistfilter_foreignkey

Reported by: charettes Owned by: baylee
Component: contrib.admin Version: master
Severity: Normal Keywords: afraid-to-commit
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Change History (9)

comment:1 Changed 10 months ago by timgraham

Also reported in #23285 (failure is there in case link to Jenkins goes stale before this is addressed).

comment:2 Changed 10 months ago by charettes

  • Description modified (diff)

comment:3 Changed 10 months ago by charettes

Failure

Lists differ: [(146, 'lisa'), (144, 'alfred'), (145, 'bob')] != [(144, 'alfred'), (145, 'bob'), (146, 'lisa')]  First differing element 0: (146, 'lisa') (144, 'alfred')  - [(146, 'lisa'), (144, 'alfred'), (145, 'bob')] + [(144, 'alfred'), (145, 'bob'), (146, 'lisa')]

Traceback

Traceback (most recent call last):
  File "/home/jenkins/workspace/django-pull-requests/database/postgis/python/python3.4/tests/admin_filters/tests.py", line 377, in test_relatedfieldlistfilter_foreignkey
    self.assertEqual(filterspec.lookup_choices, expected)
AssertionError: Lists differ: [(146, 'lisa'), (144, 'alfred'), (145, 'bob')] != [(144, 'alfred'), (145, 'bob'), (146, 'lisa')]

First differing element 0:
(146, 'lisa')
(144, 'alfred')

- [(146, 'lisa'), (144, 'alfred'), (145, 'bob')]
+ [(144, 'alfred'), (145, 'bob'), (146, 'lisa')]

comment:4 Changed 10 months ago by aaugustin

  • Component changed from Uncategorized to contrib.admin

comment:5 Changed 10 months ago by EvilDMP

  • Keywords afraid-to-commit added

I've marked this ticket as especially suitable for people following the ​Don't be afraid to commit tutorial at the DjangoCon US 2014 sprints.

If you're tackling this ticket, please don't hesitate to ask me for guidance if you'd like any, either at the sprints themselves, or here or on the Django IRC channels, where I can be found as EvilDMP.

comment:6 Changed 10 months ago by baylee

  • Owner changed from nobody to baylee
  • Status changed from new to assigned

comment:7 Changed 10 months ago by baylee

See pull request here: https://github.com/django/django/pull/3173

Unable to duplicate the Jenkins failure locally, but visual inspection says this should work for the list ordering issue.

comment:8 Changed 10 months ago by Tim Graham <timograham@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In f7d3a6255c7ae3beb9ccdf6d20f6598061cd1bff:

Fixed #23380 -- Fixed flaky test: admin_filters.tests.ListFiltersTests.test_relatedfield

comment:9 Changed 10 months ago by Tim Graham <timograham@…>

In d3543af7509d01f396997f13ab3c3b391839a511:

Added sorting to some admin_view tests to prevent transient failures; refs #23380.

Note: See TracTickets for help on using tickets.
Back to Top