Transient failure of admin_filters.tests.ListFiltersTests.test_relatedfieldlistfilter_foreignkey

[Simon Charette]

Most likely a an ordering issue.

See this ​http://djangoci.com/job/django-pull-requests/database=postgis,python=python3.4/859/testReport/junit/admin_filters.tests/ListFiltersTests/test_relatedfieldlistfilter_foreignkey/.

[Tim Graham]

Also reported in #23285 (failure is there in case link to Jenkins goes stale before this is addressed).

[Simon Charette]

Failure

Lists differ: [(146, 'lisa'), (144, 'alfred'), (145, 'bob')] != [(144, 'alfred'), (145, 'bob'), (146, 'lisa')]  First differing element 0: (146, 'lisa') (144, 'alfred')  - [(146, 'lisa'), (144, 'alfred'), (145, 'bob')] + [(144, 'alfred'), (145, 'bob'), (146, 'lisa')]

Traceback

Traceback (most recent call last):
  File "/home/jenkins/workspace/django-pull-requests/database/postgis/python/python3.4/tests/admin_filters/tests.py", line 377, in test_relatedfieldlistfilter_foreignkey
    self.assertEqual(filterspec.lookup_choices, expected)
AssertionError: Lists differ: [(146, 'lisa'), (144, 'alfred'), (145, 'bob')] != [(144, 'alfred'), (145, 'bob'), (146, 'lisa')]

First differing element 0:
(146, 'lisa')
(144, 'alfred')

- [(146, 'lisa'), (144, 'alfred'), (145, 'bob')]
+ [(144, 'alfred'), (145, 'bob'), (146, 'lisa')]

[Daniele Procida]

I've marked this ticket as especially suitable for people following the ​Don't be afraid to commit tutorial at the DjangoCon US 2014 sprints.

If you're tackling this ticket, please don't hesitate to ask me for guidance if you'd like any, either at the sprints themselves, or here or on the Django IRC channels, where I can be found as EvilDMP.

[Baylee Feore]

See pull request here: ​https://github.com/django/django/pull/3173

Unable to duplicate the Jenkins failure locally, but visual inspection says this should work for the list ordering issue.

[Tim Graham <timograham@…>]

In f7d3a6255c7ae3beb9ccdf6d20f6598061cd1bff:

Fixed #23380 -- Fixed flaky test: admin_filters.tests.ListFiltersTests.test_relatedfield

[Tim Graham <timograham@…>]

In d3543af7509d01f396997f13ab3c3b391839a511:

Added sorting to some admin_view tests to prevent transient failures; refs #23380.