Opened 10 years ago

Closed 9 years ago

#23311 closed Bug (fixed)

Windows/Python 3 test failure: test_comments_extractor

Reported by: Tim Graham Owned by: nobody
Component: Internationalization Version: dev
Severity: Normal Keywords: makemessages "Translators:" comments windows-test-failure
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


FAIL: test_comments_extractor (i18n.test_extraction.BasicExtractorTests)
Traceback (most recent call last):
  File "c:\Users\Tim\django\tests\i18n\", line 151, in test_comments_extractor
    self.assertTrue('#. Translators: One-line translator comment #5 -- with non ASCII characters: áéíóúö' in po_contents)
AssertionError: False is not true

Change History (3)

comment:1 by Ramiro Morales, 10 years ago

Keywords: makemessages "Translators:" comments added

This issue (i.e. the reported test failing on Windows+Python3):

comment:2 by Tim Graham, 9 years ago

Keywords: windows-test-failure added

comment:3 by Ramiro Morales <ramiro@…>, 9 years ago

Resolution: fixed
Status: newclosed

In 6fb9dee470d57882e378247fd2706d5f9867b5f9:

Fixed #23271 -- Don't corrupt PO files on Windows when updating them.

Make sure PO catalog text fetched from gettext programs via standard
output isn't corrupted by mismatch between assumed (UTF-8) and real
(CP1252) encodings. This can cause mojibake to be written when creating
or updating PO files.

Also fixes #23311.

Thanks to contributor with Trac nick 'danielmenzel' for the report,
excellent research and fix.

Note: See TracTickets for help on using tickets.
Back to Top