Opened 2 years ago

Closed 2 years ago

#23281 closed Cleanup/optimization (fixed)

Add explicit link into OneToOneField.parent_link

Reported by: knowledgepoint-devs Owned by: Orlando Romero
Component: Documentation Version: 1.6
Severity: Normal Keywords: afraid-to-commit
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

Documentation for OneToOneField.parent_link in Django 1.6 (https://docs.djangoproject.com/en/1.6/ref/models/fields/#django.db.models.OneToOneField.parent_link) says this field is relevant for a "model which inherits from another (concrete) model". This is rather ambiguous to users not familiar with multi-table inheritance, so I suggest adding a link from there to https://docs.djangoproject.com/en/1.6/topics/db/models/#multi-table-inheritance.

Change History (4)

comment:1 Changed 2 years ago by Baptiste Mispelon

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted
Type: UncategorizedCleanup/optimization

Hi,

Yes, I agree that this could be off-putting.
However, I don't know if just adding a link would be sufficient, since the term "concrete" doesn't appear on the linked page either.

How about mentionning in passing that non-abstract models are also sometimes called concrete?

Thanks.

comment:2 Changed 2 years ago by Daniele Procida

Keywords: afraid-to-commit added

I've marked this ticket as especially suitable for people following the ​Don't be afraid to commit tutorial at the DjangoCon US 2014 sprints.

If you're tackling this ticket, please don't hesitate to ask me for guidance if you'd like any, either at the sprints themselves, or here or on the Django IRC channels, where I can be found as EvilDMP.

comment:3 Changed 2 years ago by Orlando Romero

Owner: changed from nobody to Orlando Romero
Status: newassigned

comment:4 Changed 2 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: assignedclosed

In 60c38c1a4e482ef86465c9ac40e0b47af175ffa7:

Fixed #23281 -- Added "concrete model" to glossary.

Thanks knowledgepoint-devs for the suggestion.

Note: See TracTickets for help on using tickets.
Back to Top