Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#23156 closed Bug (fixed)

BinaryField is missing a deconstruct() method

Reported by: Baptiste Mispelon Owned by: Baptiste Mispelon
Component: Migrations Version: 1.7-rc-2
Severity: Release blocker Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

BinaryField.__init__() overrides editable=False but doesn't define a deconstruct() method which means that migrations incorrectly include editable=False.

Pull request incoming.

Change History (4)

comment:1 by Baptiste Mispelon, 10 years ago

Has patch: set

PR here: ​https://github.com/django/django/pull/3010

comment:2 by Baptiste Mispelon, 10 years ago

I found a similar bug in TimeField.deconstruct() so I added a commit to the above pull request.

comment:3 by Baptiste Mispelon <bmispelon@…>, 10 years ago

Resolution: → fixed
Status: new → closed

In 72f1eb48df335c110f39d56f7978d95896a56bb8:

Fixed #23156 -- Added missing BinaryField.deconstruct() method.

comment:4 by Baptiste Mispelon <bmispelon@…>, 10 years ago

In 23b0d636d3dc8b37fee6dc7539b0cd1f245b673a:

[1.7.x] Fixed #23156 -- Added missing BinaryField.deconstruct() method.

Backport of 72f1eb48df335c110f39d56f7978d95896a56bb8 from master.

Note: See TracTickets for help on using tickets.
Back to Top