Code

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#2312 closed defect (fixed)

E-mail validator should accept new TLDs such as ".museum"

Reported by: anonymous Owned by: adrian
Component: contrib.admin Version: master
Severity: minor Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Id doesn't accept new TLDs like .museum

Attachments (0)

Change History (5)

comment:1 Changed 8 years ago by adrian

  • Resolution set to wontfix
  • Status changed from new to closed
  • Summary changed from Admin e-mail validation problem. to E-mail validator should accept new TLDs such as ".museum"

comment:2 Changed 8 years ago by anonymous

why is this a wontfix?

comment:3 Changed 8 years ago by anonymous

interesting, i would like to know as well.

changing

r')@(?:[A-Z0-9-]+\.)+[A-Z]{2,4}$', re.IGNORECASE)  # domain

to

r')@(?:[A-Z0-9-]+\.)+[A-Z]{2,6}$', re.IGNORECASE)  # domain

you get

email_re = re.compile(
    r"(^[-!#$%&'*+/=?^_`{}|~0-9A-Z]+(\.[-!#$%&'*+/=?^_`{}|~0-9A-Z]+)*"  # dot-atom
    r'|^"([\001-\010\013\014\016-\037!#-\[\]-\177]|\\[\001-011\013\014\016-\177])*"' # quoted-string
    r')@(?:[A-Z0-9-]+\.)+[A-Z]{2,6}$', re.IGNORECASE)  # domain

which should work

comment:4 Changed 8 years ago by SmileyChris

  • Resolution wontfix deleted
  • Status changed from closed to reopened

I see no reason why this shouldn't be fixed, .museum is a valid TLD.

Adrian, would you care to explain why?

comment:5 Changed 8 years ago by adrian

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [3305]) Fixed #2312 -- E-mail validator now accepts TLDs up to 6 characters long

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.