Opened 14 months ago

Closed 14 months ago

Last modified 14 months ago

#22836 closed Cleanup/optimization (fixed)

Issue on the code in the documentation

Reported by: anonymous Owned by: maxocub
Component: Documentation Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

https://docs.djangoproject.com/en/1.6/intro/tutorial05/#improving-our-view

I have made this tutorial and there was an issue loading the model or queryset in the class.IndexView. After defining the Poll.model it worked. Thanks for this nice comminity and all the work. Keep going ;)

Change History (5)

comment:1 Changed 14 months ago by bmispelon

  • Easy pickings set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

Hi,

Do you mean that the import statements are missing at the top of the code?

As mentionned in the introduction at the top of the page, part 5 of the tutorial builds on part 4 where the IndexView should have been defined already and that part has all the correct imports from what I can tell: https://docs.djangoproject.com/en/1.6/intro/tutorial04/#amend-views

I'm not sure that reproducing all the imports in this section of part 5 would be so beneficial (but I'm open to hear your point of you if you disagree).

However, I think there's one simple improvement we could make:

In the section you linked to, the "Tutorial 4" link points to the top of the page, but it could be easier for the reader if it pointed to the paragraph where the view has been defined, which is this one: https://docs.djangoproject.com/en/1.6/intro/tutorial04/#amend-views

So I'm going to mark this ticket as accepted for this reason.

Thanks for your feedback!

comment:2 Changed 14 months ago by maxocub

  • Owner changed from nobody to maxocub
  • Status changed from new to assigned
  • Version changed from 1.6 to master

comment:3 Changed 14 months ago by maxocub

  • Has patch set

Here's my PR.

comment:4 Changed 14 months ago by Tim Graham <timograham@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 608aa8d101b03004ed2181fac82d8f3d28253bbd:

Fixed #22836 -- Linked tutorial05 to the right section of tutorial04.

comment:5 Changed 14 months ago by Tim Graham <timograham@…>

In 0b871ec22a3397063a0150d26efc0d1e1a293108:

[1.7.x] Fixed #22836 -- Linked tutorial05 to the right section of tutorial04.

Backport of 608aa8d101 from master

Note: See TracTickets for help on using tickets.
Back to Top