Opened 10 years ago

Closed 10 years ago

Last modified 9 years ago

#22835 closed Cleanup/optimization (fixed)

Deprecate NoArgsCommand

Reported by: Claude Paroz Owned by: Maxime Turcotte
Component: Core (Management commands) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Now that management command parsing is done through argparse, the NoArgsCommand is not especially useful, as with argparse, no arguments are accepted by default except when specified by add_argument.

Change History (9)

comment:1 by Maxime Turcotte, 10 years ago

Owner: changed from nobody to Maxime Turcotte
Status: new → assigned

comment:2 by Maxime Turcotte, 10 years ago

Has patch: set

comment:3 by Maxime Turcotte, 10 years ago

Here's my ​PR

comment:4 by Claude Paroz, 10 years ago

Triage Stage: Accepted → Ready for checkin

Looks good to me.

comment:5 by Tim Graham, 10 years ago

Patch needs improvement: set
Triage Stage: Ready for checkin → Accepted

Left some cosmetic comments but staticfiles_tests are also failing.

comment:6 by Maxime Turcotte, 10 years ago

I have updated my ​PR so the staticfiles_tests won't fail anymore.

comment:7 by Tim Graham <timograham@…>, 10 years ago

Resolution: → fixed
Status: assigned → closed

In 9996158db467f9bef8243fcc36dc3602570e3613:

Fixed #22835 -- Deprecated NoArgsCommand.

comment:8 by Maxime Turcotte, 10 years ago

Patch needs improvement: unset

comment:9 by Tim Graham <timograham@…>, 9 years ago

In b4002a2:

Refs #22835 -- Removed NoArgsCommand per deprecation timeline.

Note: See TracTickets for help on using tickets.
Back to Top