Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#22661 closed Cleanup/optimization (fixed)

MakeMigrationTests placed inside MigrateTests class

Reported by: Huu Nguyen Owned by: Huu Nguyen
Component: Migrations Version: 1.7-beta-2
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

In tests/migrations/test_commands.py, the tests ​here should be moved into the MakeMigrationsTests class because they test the makemigration command, not the migrate command.

Change History (7)

comment:1 by Tim Graham, 10 years ago

Triage Stage: Unreviewed → Accepted

comment:2 by Huu Nguyen, 10 years ago

Owner: changed from nobody to Huu Nguyen
Status: new → assigned

comment:3 by Huu Nguyen, 10 years ago

Opened up a pull request for this ​here.

comment:4 by Huu Nguyen, 10 years ago

Has patch: set

comment:5 by Huu Nguyen <huu@…>, 10 years ago

Resolution: → fixed
Status: assigned → closed

In 44304cf04e46cf7fa974571efd24716e03e05f94:

Fixed #22661 -- Move makemigrations tests to the proper class

comment:6 by Claude Paroz <claude@…>, 10 years ago

In 07b6404d2245519fd88c2d51b4455ed099d3a1f0:

Merge pull request #2688 from whoshuu/22661

Fixed #22661 -- Move makemigrations tests to the proper class

comment:7 by Tim Graham <timograham@…>, 10 years ago

In f7270dcd9d655f037604cf6044306582875dfbf4:

[1.7.x] Fixed #22661 -- Move makemigrations tests to the proper class

Backport of 44304cf04e from master

Note: See TracTickets for help on using tickets.
Back to Top