#22649 closed Bug (fixed)
SchemaEditor.quote_value is very fragile.
| Reported by: | loic84 | Owned by: | nobody |
|---|---|---|---|
| Component: | Migrations | Version: | 1.7-beta-2 |
| Severity: | Release blocker | Keywords: | |
| Cc: | Andrew Godwin | Triage Stage: | Accepted |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
- Quotes in a default value will break SQLite and MySQL. (https://github.com/django/django/blob/master/django/db/backends/sqlite3/schema.py#L28)
- Oracle doesn't support
bytesand breaks onBinaryField. - Oracle uses
reprto quotesix.string_types, which will probably result in an extrauprefix. (https://github.com/django/django/blob/master/django/db/backends/oracle/schema.py#L24)
The PR for #22424 (https://github.com/django/django/pull/2634) contains tests failing in various configurations.
Change History (3)
comment:1 by , 10 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:2 by , 10 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
In 125b3d440761efca8fa808a4b815384ece847d6a: