Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#22648 closed Bug (fixed)

Overridden get_lookup/get_transform not chainable

Reported by: Marc Tamlyn Owned by: nobody
Component: Database layer (models, ORM) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

If a transform has an output_type which has a customised get_transform or get_lookup function, then it is not properly called.

Change History (5)

comment:2 by Marc Tamlyn <marc.tamlyn@…>, 10 years ago

Resolution: fixed
Status: newclosed

In a2dd618e3b4a7472fab852da450ca5eef92a922f:

Fixed #22648 -- Transform.output_type should respect overridden custom_lookup and custom_transform.

Previously, class lookups from the output_type would be used, but any
changes to custom_lookup or custom_transform would be ignored.

comment:3 by Florian Apolloner, 10 years ago

Needs backport to 1.7, also see the fix in https://github.com/django/django/commit/5a2556afb9b1b3ef6e0622552970c67ac84ecd28 -- not sure if field_type should ever be None, please fix in the process of backporting.

comment:4 by Marc Tamlyn <marc.tamlyn@…>, 10 years ago

In c38925a6018a7943936d1fd2b9038ab5de406545:

[1.7.x] Fixed #22648 -- Transform.output_type should respect overridden custom_lookup and custom_transform.

Previously, class lookups from the output_type would be used, but any
changes to custom_lookup or custom_transform would be ignored.

Backport of a2dd618 from master

comment:5 by Marc Tamlyn <marc.tamlyn@…>, 10 years ago

In c38925a6018a7943936d1fd2b9038ab5de406545:

[1.7.x] Fixed #22648 -- Transform.output_type should respect overridden custom_lookup and custom_transform.

Previously, class lookups from the output_type would be used, but any
changes to custom_lookup or custom_transform would be ignored.

Backport of a2dd618 from master

Note: See TracTickets for help on using tickets.
Back to Top