Opened 13 months ago

Closed 13 months ago

Last modified 13 months ago

#22464 closed Bug (fixed)

1.7b1 tarball missing contrib/gis/static

Reported by: michael@… Owned by: nobody
Component: Packaging Version: 1.7-beta-1
Severity: Release blocker Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The tar download at https://www.djangoproject.com/download/1.7b1/tarball/ does not contain a django/contrib/gis/static directory.

This is present in the source: https://github.com/django/django/tree/stable/1.7.x/django/contrib/gis/static/gis/js

Without the JS file contained here, OLMapWidget.js, geospatial fields do not appear in the admin.

Change History (7)

comment:1 Changed 13 months ago by bmispelon

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Severity changed from Normal to Release blocker
  • Triage Stage changed from Unreviewed to Accepted

Hi,

I have no idea why that's happening, but we should definitely fix this for the final release.

Thanks!

comment:2 follow-up: Changed 13 months ago by claudep

It's probably MANIFEST.in missing the recursive-include django/contrib/gis/static * line. But this line was also absent from the 1.6 release and the js file is still in the 1.6 tarball. Did we change the packaging method?

comment:3 in reply to: ↑ 2 Changed 13 months ago by timo

Yes, we switched to setuptools in 66f546b90624297858b0f958abbe5c2b3e8bdffb.

comment:5 Changed 13 months ago by Moayad Mardini <moayad.m@…>

  • Resolution set to fixed
  • Status changed from new to closed

In bad4721b45e0a3e05b6122644e5da41616313ffe:

Fixed #22464 - included contrib/gis/static in tarball

After switching to setuptools in commit 66f546b,
contrib/gis/static isn't included in tarball anymore, this commit adds
that path to be recursive-include in MANIFEST.in

comment:6 Changed 13 months ago by Alex Gaynor <alex.gaynor@…>

In f293063c201b9ccc5258fc288b483697461e8116:

Merge pull request #2586 from mmardini/patch-2

Fixed #22464 - included contrib/gis/static in tarball

comment:7 Changed 13 months ago by Tim Graham <timograham@…>

In bdfa3fd9b3b93ad94e8de7fe3b4c38d395368812:

[1.7.x] Fixed #22464 - included contrib/gis/static in tarball

After switching to setuptools in commit 66f546b,
contrib/gis/static isn't included in tarball anymore, this commit adds
that path to be recursive-include in MANIFEST.in

Backport of bad4721b45 from master

Note: See TracTickets for help on using tickets.
Back to Top