Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#22464 closed Bug (fixed)

1.7b1 tarball missing contrib/gis/static

Reported by: michael@… Owned by: nobody
Component: Packaging Version: 1.7-beta-1
Severity: Release blocker Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The tar download at https://www.djangoproject.com/download/1.7b1/tarball/ does not contain a django/contrib/gis/static directory.

This is present in the source: https://github.com/django/django/tree/stable/1.7.x/django/contrib/gis/static/gis/js

Without the JS file contained here, OLMapWidget.js, geospatial fields do not appear in the admin.

Change History (7)

comment:1 by Baptiste Mispelon, 10 years ago

Severity: NormalRelease blocker
Triage Stage: UnreviewedAccepted

Hi,

I have no idea why that's happening, but we should definitely fix this for the final release.

Thanks!

comment:2 by Claude Paroz, 10 years ago

It's probably MANIFEST.in missing the recursive-include django/contrib/gis/static * line. But this line was also absent from the 1.6 release and the js file is still in the 1.6 tarball. Did we change the packaging method?

in reply to:  2 comment:3 by Tim Graham, 10 years ago

Yes, we switched to setuptools in 66f546b90624297858b0f958abbe5c2b3e8bdffb.

comment:5 by Moayad Mardini <moayad.m@…>, 10 years ago

Resolution: fixed
Status: newclosed

In bad4721b45e0a3e05b6122644e5da41616313ffe:

Fixed #22464 - included contrib/gis/static in tarball

After switching to setuptools in commit 66f546b,
contrib/gis/static isn't included in tarball anymore, this commit adds
that path to be recursive-include in MANIFEST.in

comment:6 by Alex Gaynor <alex.gaynor@…>, 10 years ago

In f293063c201b9ccc5258fc288b483697461e8116:

Merge pull request #2586 from mmardini/patch-2

Fixed #22464 - included contrib/gis/static in tarball

comment:7 by Tim Graham <timograham@…>, 10 years ago

In bdfa3fd9b3b93ad94e8de7fe3b4c38d395368812:

[1.7.x] Fixed #22464 - included contrib/gis/static in tarball

After switching to setuptools in commit 66f546b,
contrib/gis/static isn't included in tarball anymore, this commit adds
that path to be recursive-include in MANIFEST.in

Backport of bad4721b45 from master

Note: See TracTickets for help on using tickets.
Back to Top